From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: linux-next: Tree for August 14 (sysfs/acpi errors) Date: Sun, 17 Aug 2008 20:48:51 -0700 Message-ID: <20080818034851.GB30843@kroah.com> References: <3ae72650808150427q364842ccicf0a0978b30ca98c@mail.gmail.com> <20080815085836.67e420f1.randy.dunlap@oracle.com> <1218854219.3629.30.camel@lgn.site> <48A64235.2030108@linux.intel.com> <1218856798.3629.45.camel@lgn.site> <48A64E0A.8090408@linux.intel.com> <20080816044714.GA19886@kroah.com> <48A78D4A.70609@linux.intel.com> <20080817034051.GA26849@kroah.com> <87hc9kxpp8.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87hc9kxpp8.fsf@basil.nowhere.org> Sender: linux-next-owner@vger.kernel.org To: Andi Kleen Cc: Kay Sievers , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-acpi@vger.kernel.org, rusty@rustcorp.com.au List-Id: linux-acpi@vger.kernel.org On Sun, Aug 17, 2008 at 05:53:07AM +0200, Andi Kleen wrote: > Greg KH writes: > >> No! > > > > What you are doing here is wrong, trying to create two files with the > > same name. You just should not be doing that at all, it's that simple. > > Fix the broken code/link order, don't paper it over in the sysfs layer. > > Sorry, but relying on link order for anything is a mistake. It is subtle > and fragile and just means it'll eventually break again because it's > near impossible to properly maintain. We rely on link order for all sorts of things, this isn't new at all. thanks, greg k-h