From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Len Brown <lenb@kernel.org>, Adam M Belay <abelay@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Renninger <trenn@suse.de>, Dave Jones <davej@redhat.com>,
Ben Collins <bcollins@ubuntu.com>,
Dann Frazier <dannf@debian.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] PNP: convert the last few pnp_info() uses to printk()
Date: Tue, 19 Aug 2008 16:53:26 -0600 [thread overview]
Message-ID: <20080819225326.28206.96184.stgit@tigger.helgaas> (raw)
In-Reply-To: <20080819225310.28206.1011.stgit@tigger.helgaas>
There are only a few remaining uses of pnp_info(), so I just
converted them to printk and removed the pnp_err(), pnp_info(),
pnp_warn(), and pnp_dbg() wrappers.
I also removed a couple debug messages that don't seem useful any
more ("driver registered", "driver unregistered", "driver attached").
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/driver.c | 4 ----
drivers/pnp/pnpacpi/core.c | 6 +++---
include/linux/pnp.h | 10 ----------
3 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index d3f869e..54673a4 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -114,7 +114,6 @@ static int pnp_device_probe(struct device *dev)
} else
goto fail;
- dev_dbg(dev, "driver attached\n");
return error;
fail:
@@ -210,8 +209,6 @@ struct bus_type pnp_bus_type = {
int pnp_register_driver(struct pnp_driver *drv)
{
- pnp_dbg("the driver '%s' has been registered", drv->name);
-
drv->driver.name = drv->name;
drv->driver.bus = &pnp_bus_type;
@@ -221,7 +218,6 @@ int pnp_register_driver(struct pnp_driver *drv)
void pnp_unregister_driver(struct pnp_driver *drv)
{
driver_unregister(&drv->driver);
- pnp_dbg("the driver '%s' has been unregistered", drv->name);
}
/**
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index c1b9ea3..67c651b 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -255,14 +255,14 @@ int pnpacpi_disabled __initdata;
static int __init pnpacpi_init(void)
{
if (acpi_disabled || pnpacpi_disabled) {
- pnp_info("PnP ACPI: disabled");
+ printk(KERN_INFO "pnp: PnP ACPI: disabled\n");
return 0;
}
- pnp_info("PnP ACPI init");
+ printk(KERN_INFO "pnp: PnP ACPI init\n");
pnp_register_protocol(&pnpacpi_protocol);
register_acpi_bus_type(&acpi_pnp_bus);
acpi_get_devices(NULL, pnpacpi_add_device_handler, NULL, NULL);
- pnp_info("PnP ACPI: found %d devices", num);
+ printk(KERN_INFO "pnp: PnP ACPI: found %d devices\n", num);
unregister_acpi_bus_type(&acpi_pnp_bus);
pnp_platform_devices = 1;
return 0;
diff --git a/include/linux/pnp.h b/include/linux/pnp.h
index 1ce54b6..8d1c5ce 100644
--- a/include/linux/pnp.h
+++ b/include/linux/pnp.h
@@ -476,14 +476,4 @@ static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
#endif /* CONFIG_PNP */
-#define pnp_err(format, arg...) printk(KERN_ERR "pnp: " format "\n" , ## arg)
-#define pnp_info(format, arg...) printk(KERN_INFO "pnp: " format "\n" , ## arg)
-#define pnp_warn(format, arg...) printk(KERN_WARNING "pnp: " format "\n" , ## arg)
-
-#ifdef CONFIG_PNP_DEBUG
-#define pnp_dbg(format, arg...) printk(KERN_DEBUG "pnp: " format "\n" , ## arg)
-#else
-#define pnp_dbg(format, arg...) do {} while (0)
-#endif
-
#endif /* _LINUX_PNP_H */
next prev parent reply other threads:[~2008-08-19 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 22:53 [PATCH 0/8] PNP debugging rework Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 1/8] PNP: fix debug formatting (cosmetic) Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 2/8] PNPACPI: use dev_printk when possible Bjorn Helgaas
2008-08-19 22:53 ` Bjorn Helgaas [this message]
2008-08-19 22:53 ` [PATCH 4/8] PNP: use new vsprintf symbolic function pointer format Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 5/8] PNP: remove some uses of DEBUG ifdef Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 6/8] PNP: add CONFIG_PNP_DEBUG_MESSAGES and pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 7/8] PNP: convert to using pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 8/8] PNP: remove old CONFIG_PNP_DEBUG option Bjorn Helgaas
2008-08-20 2:54 ` [PATCH 0/8] PNP debugging rework Andi Kleen
2008-08-20 14:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819225326.28206.96184.stgit@tigger.helgaas \
--to=bjorn.helgaas@hp.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bcollins@ubuntu.com \
--cc=dannf@debian.org \
--cc=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox