From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Len Brown <lenb@kernel.org>, Adam M Belay <abelay@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Renninger <trenn@suse.de>, Dave Jones <davej@redhat.com>,
Ben Collins <bcollins@ubuntu.com>,
Dann Frazier <dannf@debian.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] PNP: use new vsprintf symbolic function pointer format
Date: Tue, 19 Aug 2008 16:53:31 -0600 [thread overview]
Message-ID: <20080819225331.28206.82730.stgit@tigger.helgaas> (raw)
In-Reply-To: <20080819225310.28206.1011.stgit@tigger.helgaas>
Use the '%pF' format to get rid of an "#ifdef DEBUG".
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/quirks.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index 0bdf9b8..414bb09 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -337,10 +337,8 @@ void pnp_fixup_device(struct pnp_dev *dev)
for (f = pnp_fixups; *f->id; f++) {
if (!compare_pnp_id(dev->id, f->id))
continue;
-#ifdef DEBUG
- dev_dbg(&dev->dev, "%s: calling ", f->id);
- print_fn_descriptor_symbol("%s\n", f->quirk_function);
-#endif
+ dev_dbg(&dev->dev, "%s: calling %pF\n", f->id,
+ f->quirk_function);
f->quirk_function(dev);
}
}
next prev parent reply other threads:[~2008-08-19 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 22:53 [PATCH 0/8] PNP debugging rework Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 1/8] PNP: fix debug formatting (cosmetic) Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 2/8] PNPACPI: use dev_printk when possible Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 3/8] PNP: convert the last few pnp_info() uses to printk() Bjorn Helgaas
2008-08-19 22:53 ` Bjorn Helgaas [this message]
2008-08-19 22:53 ` [PATCH 5/8] PNP: remove some uses of DEBUG ifdef Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 6/8] PNP: add CONFIG_PNP_DEBUG_MESSAGES and pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 7/8] PNP: convert to using pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 8/8] PNP: remove old CONFIG_PNP_DEBUG option Bjorn Helgaas
2008-08-20 2:54 ` [PATCH 0/8] PNP debugging rework Andi Kleen
2008-08-20 14:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819225331.28206.82730.stgit@tigger.helgaas \
--to=bjorn.helgaas@hp.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bcollins@ubuntu.com \
--cc=dannf@debian.org \
--cc=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox