From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Len Brown <lenb@kernel.org>, Adam M Belay <abelay@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Renninger <trenn@suse.de>, Dave Jones <davej@redhat.com>,
Ben Collins <bcollins@ubuntu.com>,
Dann Frazier <dannf@debian.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 8/8] PNP: remove old CONFIG_PNP_DEBUG option
Date: Tue, 19 Aug 2008 16:53:52 -0600 [thread overview]
Message-ID: <20080819225352.28206.87012.stgit@tigger.helgaas> (raw)
In-Reply-To: <20080819225310.28206.1011.stgit@tigger.helgaas>
CONFIG_PNP_DEBUG is no longer used to turn on dev_dbg() in PNP,
since we have pnp_dbg() which can be enabled at boot-time, so
this patch removes the config option.
Note that pnp_dock_event() checks "#ifdef DEBUG". But there's
never been a clear path for enabling that via configgery. It
happened that CONFIG_PNP_DEBUG enabled it after 1bd17e63a068db6,
but that was accidental and only in 2.6.26.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/Kconfig | 6 ------
drivers/pnp/Makefile | 4 ----
drivers/pnp/isapnp/Makefile | 4 ----
drivers/pnp/pnpacpi/Makefile | 4 ----
drivers/pnp/pnpbios/Makefile | 4 ----
5 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/drivers/pnp/Kconfig b/drivers/pnp/Kconfig
index 8a3237f..2a37b3f 100644
--- a/drivers/pnp/Kconfig
+++ b/drivers/pnp/Kconfig
@@ -36,12 +36,6 @@ config PNP_DEBUG_MESSAGES
if PNP
-config PNP_DEBUG
- bool "PnP Debug Messages"
- help
- Say Y if you want the Plug and Play Layer to print debug messages.
- This is useful if you are developing a PnP driver or troubleshooting.
-
comment "Protocols"
source "drivers/pnp/isapnp/Kconfig"
diff --git a/drivers/pnp/Makefile b/drivers/pnp/Makefile
index 26f5abc..a381a92 100644
--- a/drivers/pnp/Makefile
+++ b/drivers/pnp/Makefile
@@ -7,7 +7,3 @@ obj-y := core.o card.o driver.o resource.o manager.o support.o interface.o quir
obj-$(CONFIG_PNPACPI) += pnpacpi/
obj-$(CONFIG_PNPBIOS) += pnpbios/
obj-$(CONFIG_ISAPNP) += isapnp/
-
-ifeq ($(CONFIG_PNP_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
diff --git a/drivers/pnp/isapnp/Makefile b/drivers/pnp/isapnp/Makefile
index 3e38f06..cac18bb 100644
--- a/drivers/pnp/isapnp/Makefile
+++ b/drivers/pnp/isapnp/Makefile
@@ -5,7 +5,3 @@
isapnp-proc-$(CONFIG_PROC_FS) = proc.o
obj-y := core.o compat.o $(isapnp-proc-y)
-
-ifeq ($(CONFIG_PNP_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
diff --git a/drivers/pnp/pnpacpi/Makefile b/drivers/pnp/pnpacpi/Makefile
index 2d7a1e6..905326f 100644
--- a/drivers/pnp/pnpacpi/Makefile
+++ b/drivers/pnp/pnpacpi/Makefile
@@ -3,7 +3,3 @@
#
obj-y := core.o rsparser.o
-
-ifeq ($(CONFIG_PNP_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
diff --git a/drivers/pnp/pnpbios/Makefile b/drivers/pnp/pnpbios/Makefile
index 310e2b3..3cd3ed7 100644
--- a/drivers/pnp/pnpbios/Makefile
+++ b/drivers/pnp/pnpbios/Makefile
@@ -5,7 +5,3 @@
pnpbios-proc-$(CONFIG_PNPBIOS_PROC_FS) = proc.o
obj-y := core.o bioscalls.o rsparser.o $(pnpbios-proc-y)
-
-ifeq ($(CONFIG_PNP_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
next prev parent reply other threads:[~2008-08-19 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 22:53 [PATCH 0/8] PNP debugging rework Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 1/8] PNP: fix debug formatting (cosmetic) Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 2/8] PNPACPI: use dev_printk when possible Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 3/8] PNP: convert the last few pnp_info() uses to printk() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 4/8] PNP: use new vsprintf symbolic function pointer format Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 5/8] PNP: remove some uses of DEBUG ifdef Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 6/8] PNP: add CONFIG_PNP_DEBUG_MESSAGES and pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` [PATCH 7/8] PNP: convert to using pnp_dbg() Bjorn Helgaas
2008-08-19 22:53 ` Bjorn Helgaas [this message]
2008-08-20 2:54 ` [PATCH 0/8] PNP debugging rework Andi Kleen
2008-08-20 14:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819225352.28206.87012.stgit@tigger.helgaas \
--to=bjorn.helgaas@hp.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bcollins@ubuntu.com \
--cc=dannf@debian.org \
--cc=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox