From: akpm@linux-foundation.org
To: andi@firstfloor.org
Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org,
alan-jenkins@tuffmail.co.uk, astarikovskiy@suse.de,
hmh@hmh.eng.br, maxi@daemonizer.de, stable@kernel.org
Subject: [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Wed, 20 Aug 2008 16:41:47 -0700 [thread overview]
Message-ID: <200808202341.m7KNflv7005413@imap1.linux-foundation.org> (raw)
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
It looks like this EC clears the SMI_EVT bit after every query, even if
there are more events pending. The workaround is to repeatedly query the
EC until it reports that no events remain.
This fixes a regression in 2.6.26 (from 2.6.25.3). Initially reported as
"Asus Eee PC hotkeys stop working if pressed quickly" in bugzilla
<http://bugzilla.kernel.org/show_bug.cgi?id=11089>.
The regression was caused by a recently added check for interrupt storms.
The Eee PC triggers this check and switches to polling. When multiple
events arrive between polling intervals, only one is fetched from the EC.
This causes erroneous behaviour; ultimately events stop being delivered
altogether when the EC buffer overflows.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Maximilian Engelhardt <maxi@daemonizer.de>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/ec.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff -puN drivers/acpi/ec.c~acpi-avoid-dropping-rapid-hotkey-events-or-other-gpes-on-asus-eeepc drivers/acpi/ec.c
--- a/drivers/acpi/ec.c~acpi-avoid-dropping-rapid-hotkey-events-or-other-gpes-on-asus-eeepc
+++ a/drivers/acpi/ec.c
@@ -486,14 +486,10 @@ void acpi_ec_remove_query_handler(struct
EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);
-static void acpi_ec_gpe_query(void *ec_cxt)
+static void acpi_ec_gpe_run_handler(struct acpi_ec *ec, u8 value)
{
- struct acpi_ec *ec = ec_cxt;
- u8 value = 0;
struct acpi_ec_query_handler *handler, copy;
- if (!ec || acpi_ec_query(ec, &value))
- return;
mutex_lock(&ec->lock);
list_for_each_entry(handler, &ec->list, node) {
if (value == handler->query_bit) {
@@ -511,6 +507,18 @@ static void acpi_ec_gpe_query(void *ec_c
mutex_unlock(&ec->lock);
}
+static void acpi_ec_gpe_query(void *ec_cxt)
+{
+ struct acpi_ec *ec = ec_cxt;
+ u8 value = 0;
+
+ if (!ec)
+ return;
+
+ while (!acpi_ec_query(ec, &value))
+ acpi_ec_gpe_run_handler(ec, value);
+}
+
static u32 acpi_ec_gpe_handler(void *data)
{
acpi_status status = AE_OK;
_
next reply other threads:[~2008-08-20 23:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 23:41 akpm [this message]
2008-08-21 12:12 ` [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Alexey Starikovskiy
2008-08-21 12:22 ` Andi Kleen
2008-08-21 16:18 ` Andrew Morton
2008-08-21 13:35 ` Alan Jenkins
2008-08-21 13:55 ` Alexey Starikovskiy
2008-08-21 14:42 ` Alan Jenkins
2008-08-21 16:01 ` Alexey Starikovskiy
2008-08-22 10:50 ` Alan Jenkins
2008-08-23 11:31 ` Alan Jenkins
-- strict thread matches above, loose matches on Subject: below --
2008-09-21 18:42 Alan Jenkins
2008-09-21 19:17 ` Alexey Starikovskiy
2008-09-22 1:31 ` Zhao Yakui
2008-09-22 9:08 ` Alan Jenkins
2008-09-22 11:02 ` Alan Jenkins
2008-09-22 11:36 ` Alexey Starikovskiy
2008-09-22 11:49 ` Alexey Starikovskiy
2008-09-22 12:30 ` Alan Jenkins
2008-09-22 12:35 ` Alexey Starikovskiy
2008-09-22 13:44 ` Alan Jenkins
2008-09-22 19:36 ` Alexey Starikovskiy
2008-09-23 6:19 ` Zhao Yakui
2008-09-22 1:20 ` Zhao Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808202341.m7KNflv7005413@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=andi@firstfloor.org \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox