From: Thomas Renninger <trenn@suse.de>
To: Zhang Rui <rui.zhang@intel.com>
Cc: khali@linux-fr.org, linux-acpi@vger.kernel.org,
Len Brown <len.brown@intel.com>,
robert.moore@intel.com, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 2/2] Give ACPI hwmon thermal devices a name if BIOS provides one
Date: Mon, 25 Aug 2008 12:48:30 +0200 [thread overview]
Message-ID: <200808251248.31786.trenn@suse.de> (raw)
In-Reply-To: <1219630502.24775.35.camel@rzhang-dt>
On Monday 25 August 2008 04:15:02 Zhang Rui wrote:
> On Mon, 2008-08-25 at 06:20 +0800, Thomas Renninger wrote:
> > On Monday 25 August 2008 12:11:37 am Thomas Renninger wrote:
> > > On a HP tx2500z laptop one thermal device provides this function:
> > > Name (REGN, "Processor Thermal Zone")
> >
> > I wonder what we can do to get this added to the ACPI spec or to make
> > vendors use the same function for this.
> >
> > What about trying for above "REGN" as it already exists on HPs.
> > Also try for _NAM (or similar), document that we do this and tell
> > vendors that it's a good thing to provide a sane string/name for
> > thermal_zones on Linux.
> >
> > On ACPI everything that does not start with "_" means unspecified
> > and the function should only be used internally and not by the OS...
>
> Sounds good. But I guess it's not easy to push this the vendors, is it?
At least this is a really easy thing for them to add.
I wonder how localization should work here. One does not want to add
the description of the thermal zone in all possibly supported languages
into BIOS ROM.
Pre-defining 10 different areas:
0 Processor
1 Memory
2 Disk
3 Graphics card
4 ...
10 Others
and then returning an integer value sounds more sane.
If Len or Bob say it makes sense to come up with or add something which
we can tell the vendors to use and which may find its way to a later Spec
version...
After first being excited that HP provided a sane description of a thermal
zone, I think it's not worth adding this right now (or is it?).
Thomas
PS: Forgot to add lm-sensors list, adding them now.
next prev parent reply other threads:[~2008-08-25 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 20:34 Thermal zone names Jean Delvare
2008-08-21 1:36 ` Zhang Rui
2008-08-21 15:48 ` Jean Delvare
2008-08-24 22:06 ` Thomas Renninger
2008-08-24 22:11 ` [RFC PATCH] Read name/location of thermal zone from ACPI function and pass it to hwmon Thomas Renninger
2008-08-24 22:11 ` [PATCH 1/2] patch acpi_introduce_evaluate_string.patch Thomas Renninger
2008-08-25 1:31 ` Zhao Yakui
2008-08-24 22:11 ` [PATCH 2/2] Give ACPI hwmon thermal devices a name if BIOS provides one Thomas Renninger
2008-08-24 22:20 ` Thomas Renninger
2008-08-25 2:15 ` Zhang Rui
2008-08-25 10:48 ` Thomas Renninger [this message]
2008-08-25 1:58 ` Zhang Rui
2008-08-25 7:44 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808251248.31786.trenn@suse.de \
--to=trenn@suse.de \
--cc=khali@linux-fr.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox