From: Andi Kleen <andi@firstfloor.org>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: "Joshua C." <joshuacov@googlemail.com>,
linux-acpi@vger.kernel.org, andi@firstfloor.org, lenb@kernel.org
Subject: Re: How can a patch be merged upstream?
Date: Thu, 28 Aug 2008 01:09:39 +0200 [thread overview]
Message-ID: <20080827230939.GF26610@one.firstfloor.org> (raw)
In-Reply-To: <1219712802.4116.32.camel@yakui_zhao.sh.intel.com>
> Linux can't work normally while Windows can work on such broken BIOS. Of
> course the issue is related with the broken BIOS. The _REG object of EC
> device is incorrect, which causes that EC device can't be initialized
> correctly.
> After this workaround patch is applied, Linux can also work. IMO this
> workaround patch is reasonable.
Can you please submit it with proper description?
> > + if (status == AE_NOT_FOUND) {
> > + /*
> > + * Maybe OS fails in evaluating the _REG object.
> > + * The AE_NOT_FOUND error will be ignored and OS
> > + * continue to initialize EC.
> > + */
> > + printk(KERN_ERR "Fail in evaluating _REG object."
> > + " It is broken BIOS.\n");
The English could be improved.
"Failure in evaluation _REG object .... Broken BIOS suspected."
Also could you output the path to the object too for easier
diagnosis?
-Andi
next prev parent reply other threads:[~2008-08-27 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 14:26 How can a patch be merged upstream? Joshua C.
2008-08-26 1:06 ` Zhao Yakui
2008-08-27 23:09 ` Andi Kleen [this message]
2008-08-27 23:11 ` Carlos Corbacho
2008-08-27 23:37 ` Andi Kleen
2008-08-28 1:18 ` Zhao Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827230939.GF26610@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=joshuacov@googlemail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox