Re: 2.6.26.[1-3] + x61 tablet + x6ultrabase: no resume after?undocking

Holger Macht
2008-09-05T09:00:19Z

On Wed 03. Sep - 18:28:27, Henrique de Moraes Holschuh wrote:
> (Holger dropped from CC/To as requested by the mail-followup-to header).
>
> On Wed, 03 Sep 2008, Holger Macht wrote:
> > On Mon 01. Sep - 12:05:04, Steven King wrote:
> > > On Monday 01 September 2008 5:16:44 Tomas Carnecky wrote:
> > >
> > > > I just tested suspend/resume with the CDROM drive removed (an empty
> > > > bay). Suspend/resume now works just fine, regardless how I dock/undock
> > > > the laptop.
> > >
> > > I'm seeing the exact same things as Tom. Also, in my dmesg I see:
> > >
> > > ACPI: \_SB_.PCI0.IDE0.PRIM.MSTR: found ejectable bay
> > > ACPI: \_SB_.PCI0.IDE0.PRIM.MSTR: Adding notify handler
> > > ACPI: Error installing bay notify handler
> > >
> > > is this significant?
> >
> > No, it's not. Bay driver is obsolete with 2.6.26's libata hotplug code.
>
> Hardly so. We need to be able to query state and command the bay from
> userspace. We need to support non-libata devices. We don't need, but want,
> notifications that can be easily flagged by userspace as being related to
> bay/dock ejections and insertions (for OSD).
>
> What makes bay obsolete is the rework on the dock driver that adds all bay
> functionality to dock.c... and that ain't even on 2.6.27, AFAIK.

Maybe the statement was a little bit harsh, it's just that you won't need
bay in conjunction with libata, because it can't install the notification
handler because that was already done by libata.

Regards,
Holger