From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] ACPI suspend: Always use the 32-bit waking vector Date: Mon, 15 Sep 2008 11:50:01 +0200 Message-ID: <20080915095001.GA2015@elf.ucw.cz> References: <1220507476.4007.117.camel@yakui_zhao.sh.intel.com> <1220577437.4007.148.camel@yakui_zhao.sh.intel.com> <76780B19A496DC4B80439008DAD7076C01803B89F1@PDSMSX501.ccr.corp.intel.com> <200809061313.02088.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from gprs189-60.eurotel.cz ([160.218.189.60]:45310 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbYIOJsn (ORCPT ); Mon, 15 Sep 2008 05:48:43 -0400 Content-Disposition: inline In-Reply-To: <200809061313.02088.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Li, Shaohua" , "Zhao, Yakui" , Matthew Garrett , "Zhang, Rui" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "andi@firstfloor.org" Hi! > Well, I read this part of the spec (2.0c, 3.0b) more carefully and it matches > what you're saying. Moreover, my understanding of it is that we should > actually _clear_ the 64-bit vector on systems that support it, because > otherwise the BIOS is supposed to use it and call the wake-up code in protected > mode. > > The appended patch is based on this observation. > > Thanks, > Rafael > > --- > From: Rafael J. Wysocki > > ACPI suspend: Always use the 32-bit waking vector > > According to the ACPI specification 2.0c and later, the 64-bit waking vector > should be cleared and the 32-bit waking vector should be used, unless we want > the wake-up code to be called by the BIOS in Protected Mode. Moreover, some > systems (for example HP dv5-1004nr) are known to fail to resume if the 64-bit > waking vector is used. Therefore, modify the code to clear the 64-bit waking > vector, for FACS version 1 or greater, and set the 32-bit one before suspend. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/acpi/hardware/hwsleep.c | 37 +++++++++++-------------------------- > 1 file changed, 11 insertions(+), 26 deletions(-) > > @@ -134,20 +132,7 @@ acpi_get_firmware_waking_vector(acpi_phy > } > > /* Get the vector */ > - > - if ((facs->length < 32) || (!(facs->xfirmware_waking_vector))) { > - /* > - * ACPI 1.0 FACS or short table or optional X_ field is zero > - */ > - *physical_address = > - (acpi_physical_address) facs->firmware_waking_vector; > - } else { > - /* > - * ACPI 2.0 FACS with valid X_ field > - */ > - *physical_address = > - (acpi_physical_address) facs->xfirmware_waking_vector; > - } > + *physical_address = (acpi_physical_address)facs->firmware_waking_vector; > > return_ACPI_STATUS(AE_OK); > } Actually, I guess we should kill acpi_get_firmware_waking_vector: It is completely useless, and it is indeed never used in whole Linux... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html