From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI: EC: do transaction from interrupt context Date: Fri, 26 Sep 2008 14:33:52 +0200 Message-ID: <200809261433.53674.rjw@sisk.pl> References: <20080925170030.15311.27823.stgit@thinkpad> <48DBCFE0.8050905@yahoo.com> <1222391199.4023.125.camel@yakui_zhao.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:60510 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbYIZM2O (ORCPT ); Fri, 26 Sep 2008 08:28:14 -0400 In-Reply-To: <1222391199.4023.125.camel@yakui_zhao.sh.intel.com> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Zhao Yakui Cc: Sitsofe Wheeler , Alexey Starikovskiy , LenBrown , Linux-acpi@vger.kernel.org On Friday, 26 of September 2008, Zhao Yakui wrote: > On Thu, 2008-09-25 at 18:52 +0100, Sitsofe Wheeler wrote: > > Alexey Starikovskiy wrote: > > > It is easier and faster to do transaction directly from interrupt context > > > rather than waking control thread. > > > Also, cleaner GPE storm avoidance is implemented. > Hi, Sitsofe > I think that the problem on the asus-EEEPC can't be resolved really > by the Alexey's patch. IMO it is only lucky. > In fact the main problem on Asus-EEEPC is related with the broken EC. > Before an EC notification event is processed, another EC notification > event arrives again. > If EC driver check whether the SCI_EVT bit is set after processing > one EC notification event, the problem will be resolved. > http://bugzilla.kernel.org/show_bug.cgi?id=11089 > Alan Jenkins already sent a patch about how to fix the issue on the > Asus-EEEPC. > > But if the above patch is merged , maybe it will break some laptops. > On my laptop when issuing the query command, a non-zero query event is > returned but it can't be processed.(There is no corresponding ACPI _Qxx > object). At the same time the SCI_EVT bit won't be cleared. In such case > OS can't exit the function of acpi_ec_query_handler, which causes that > the acpid kernel thread can't work well. So does the patch break your box as a result? Rafael