Re: Propose WMI patch

[Duarte Silva <duartejcsilva@gmail.com>]

On Tuesday 30 September 2008 12:16:10 Carlos Corbacho wrote:
> On Tuesday 30 September 2008 12:13:58 Carlos Corbacho wrote:
> > On Tuesday 30 September 2008 12:06:35 Duarte Silva wrote:
> > > I wanted to propose a ACPI-WMI API change. Instead of having,
> > > wmi_has_guid returning a boolean, why not returning a acpi_status. It
> > > would allow extented error handling, and it would look more ACPI style
> > > :)
> >
> > NAK.
> >
> > We're not interested in ACPI error codes here, since we're never going to
> > do anything with them.
> >
> > We only care if the DSDT exists or not with this method - it's just a
> > means of detection for other drivers.
>
> s/DSDT/GUID/
>
> -Carlos

On Tuesday 30 September 2008 12:16:10 you wrote:
> On Tuesday 30 September 2008 12:13:58 Carlos Corbacho wrote:
> > On Tuesday 30 September 2008 12:06:35 Duarte Silva wrote:
> > > I wanted to propose a ACPI-WMI API change. Instead of having,
> > > wmi_has_guid returning a boolean, why not returning a acpi_status. It
> > > would allow extented error handling, and it would look more ACPI style
> > > :)
> >
> > NAK.
> >
> > We're not interested in ACPI error codes here, since we're never going to
> > do anything with them.
> >
> > We only care if the DSDT exists or not with this method - it's just a
> > means of detection for other drivers.
>
> s/DSDT/GUID/
>
> -Carlos

For instance, it would be nice to be able to do this,

for (i = 0; i < ARRAY_SIZE(laptop->methods); i++)
        laptop->methods[i].status = 
wmi_is_guid_present(laptop->methods[i].guid);

instead of

for (i = 0; i < ARRAY_SIZE(laptop->methods); i++)
        if (wmi_has_guid(laptop->methods[i].guid))
                laptop->methods[i].status = AE_OK;
        else
                laptop->methods[i].status = AE_NOT_FOUND;

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html