From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH 1/3] acer-wmi: Add rfkill support for wireless and bluetooth
Date: Thu, 9 Oct 2008 01:17:15 -0400 [thread overview]
Message-ID: <20081009051715.GD11477@anvil.corenet.prv> (raw)
In-Reply-To: <20081008204021.1815.69879.stgit@localhost>
Hi Carlos,
On Wed, Oct 08, 2008 at 09:40:21PM +0100, Carlos Corbacho wrote:
> +
> + rfkill_workqueue = create_singlethread_workqueue("rfkill_workqueue");
> + if (!rfkill_workqueue) {
> + if (has_cap(ACER_CAP_BLUETOOTH)) {
> + kfree(bluetooth_rfkill->data);
> + rfkill_unregister(bluetooth_rfkill);
> + }
> + kfree(wireless_rfkill->data);
> + rfkill_unregister(wireless_rfkill);
> + return -ENOMEM;
> + }
> + queue_delayed_work(rfkill_workqueue, &acer_rfkill_work, HZ);
> +
Do we really need a private workqueue here? acer_rfkill_work seems to
be a 'quickie' and so keventd should work pretty well here, shouldn't
it?
Thanks!
--
Dmitry
next prev parent reply other threads:[~2008-10-09 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 20:40 [PATCH 0/3] WMI patches for 2.6.28 (Resend) Carlos Corbacho
2008-10-08 20:40 ` [PATCH 1/3] acer-wmi: Add rfkill support for wireless and bluetooth Carlos Corbacho
2008-10-09 5:17 ` Dmitry Torokhov [this message]
2008-10-08 20:40 ` [PATCH 2/3] acer-wmi: Remove wireless and bluetooth sysfs entries Carlos Corbacho
2008-10-08 20:40 ` [PATCH 3/3] ACPI: WMI: Enable event methods when registering notifiers Carlos Corbacho
2008-10-08 21:00 ` [PATCH 0/3] WMI patches for 2.6.28 (Resend) Len Brown
-- strict thread matches above, loose matches on Subject: below --
2008-09-15 21:32 [PATCH 0/3] WMI patches for 2.6.28 Carlos Corbacho
2008-09-15 21:32 ` [PATCH 1/3] acer-wmi: Add rfkill support for wireless and bluetooth Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009051715.GD11477@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox