Re: [PATCH 1/3] acer-wmi: Add rfkill support for wireless and bluetooth

Dmitry Torokhov
2008-10-09T05:17:19Z

Hi Carlos,

On Wed, Oct 08, 2008 at 09:40:21PM +0100, Carlos Corbacho wrote:
> +
> + rfkill_workqueue = create_singlethread_workqueue("rfkill_workqueue");
> + if (!rfkill_workqueue) {
> + if (has_cap(ACER_CAP_BLUETOOTH)) {
> + kfree(bluetooth_rfkill->data);
> + rfkill_unregister(bluetooth_rfkill);
> + }
> + kfree(wireless_rfkill->data);
> + rfkill_unregister(wireless_rfkill);
> + return -ENOMEM;
> + }
> + queue_delayed_work(rfkill_workqueue, &acer_rfkill_work, HZ);
> +

Do we really need a private workqueue here? acer_rfkill_work seems to
be a 'quickie' and so keventd should work pretty well here, shouldn't
it?

Thanks!

--
Dmitry