From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] x86: trim ACPI sleep stack buffer Date: Thu, 9 Oct 2008 20:07:47 +0200 Message-ID: <20081009180747.GC12507@elf.ucw.cz> References: <1222819957.13453.15.camel@calx> <20081009085649.GC29957@atrey.karlin.mff.cuni.cz> <1223571381.17706.94.camel@calx> <4911F71203A09E4D9981D27F9D83085803123361@orsmsx503.amr.corp.intel.com> <1223574110.17706.109.camel@calx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from gprs189-60.eurotel.cz ([160.218.189.60]:35650 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbYJISG0 (ORCPT ); Thu, 9 Oct 2008 14:06:26 -0400 Content-Disposition: inline In-Reply-To: <1223574110.17706.109.camel@calx> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matt Mackall Cc: "Moore, Robert" , Len Brown , Ingo Molnar , Linux Kernel Mailing List , "linux-acpi@vger.kernel.org" , "Rafael J. Wysocki" On Thu 2008-10-09 12:41:50, Matt Mackall wrote: > On Thu, 2008-10-09 at 10:23 -0700, Moore, Robert wrote: > > Sounds like you need a > > > > #define DEFAULT_STACK_SIZE 4096 > > > > Somewhere. > > Or maybe something like this: > > > x86: remove magic number from ACPI sleep stack buffer > > Signed-off-by: Matt Mackall Acked-by: Pavel Machek > diff -r 375a00b8bf10 arch/x86/kernel/acpi/sleep.c > --- a/arch/x86/kernel/acpi/sleep.c Thu Oct 09 12:38:55 2008 -0500 > +++ b/arch/x86/kernel/acpi/sleep.c Thu Oct 09 12:40:10 2008 -0500 > @@ -97,7 +97,7 @@ > #else /* CONFIG_64BIT */ > header->trampoline_segment = setup_trampoline() >> 4; > #ifdef CONFIG_SMP > - stack_start.sp = temp_stack + 4096; > + stack_start.sp = temp_stack + sizeof(temp_stack); > #endif > initial_code = (unsigned long)wakeup_long64; > saved_magic = 0x123456789abcdef0; > > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html