From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 53/85] i7300_idle driver v1.55 Date: Sat, 11 Oct 2008 10:33:47 +0200 Message-ID: <20081011083347.GA31918@elte.hu> References: <1d80ebdb81444701024ad9b9f026516561496a43.1223706853.git.len.brown@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:51058 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbYJKIeF (ORCPT ); Sat, 11 Oct 2008 04:34:05 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Venki Pallipadi , Andy Henroid , Len Brown , Linus Torvalds , Thomas Gleixner , "H. Peter Anvin" Len, * Len Brown wrote: > --- a/arch/x86/kernel/process_64.c > +++ b/arch/x86/kernel/process_64.c > @@ -62,6 +62,13 @@ void idle_notifier_register(struct notifier_block *n) > { > atomic_notifier_chain_register(&idle_notifier, n); > } > +EXPORT_SYMBOL_GPL(idle_notifier_register); > + > +void idle_notifier_unregister(struct notifier_block *n) > +{ > + atomic_notifier_chain_unregister(&idle_notifier, n); > +} > +EXPORT_SYMBOL_GPL(idle_notifier_unregister); hm, such x86 infrastructure changes should be submitted via the x86 tree, and you should at least have Cc:-ed the maintainers. The thing is, we are _getting rid_ of the idle notifiers, not extending them. The last thing we need is random opaque stuff getting called in weird ordering when we enter/exit idle state. We want all that be visible and have explicit, in-source-code ordering. Ingo