Re: eeepc-laptop: Use standard interfaces

Re: eeepc-laptop: Use standard interfaces

[Alan Jenkins]

I've tested this change in the acpi-test tree.  I welcome the input
events - I now get a nice on-screen display for the volume hotkeys. 
However, there's a regression which is probably related to the rfkill code.

My wireless interface dies on suspend:

[  367.430008] Restarting tasks ... done.
[  368.683300] ath5k phy0: failed to wakeup the MAC Chip
[  368.683300] ath5k phy0: unable to reset hardware: -5
[  369.933290] evdev.c(EVIOCGBIT): Suspicious buffer size 511, limiting
output to 64 bytes. See http://userweb.kernel.org/~dtor/eviocgbit-bug.html
[  371.619966] ath5k phy0: failed to wakeup the MAC Chip
[  371.619966] ath5k phy0: unable to reset hardware: -5

I can still reproduce it if I stop the "hal" and "dbus" services and use
s2ram to suspend.

I guess the rfkill subsystem automatically trips the switch to save
power in suspend.  And I don't have resume scripts with the pci hotplug
magic workaround.  So, do you still think it would be appropriate to
merge this rfkill code before the pci hotplug magic is implemented
in-kernel?

Regards
Alan

Re: eeepc-laptop: Use standard interfaces

[Matthew Garrett]

On Sat, Oct 11, 2008 at 02:47:32PM +0100, Alan Jenkins wrote:

> I guess the rfkill subsystem automatically trips the switch to save
> power in suspend.  And I don't have resume scripts with the pci hotplug
> magic workaround.  So, do you still think it would be appropriate to
> merge this rfkill code before the pci hotplug magic is implemented
> in-kernel?

The suspend/resume code in rfkill is being removed in this release 
cycle, so I don't think there's a problem.

-- 
Matthew Garrett | mjg59@srcf.ucam.org