* Re: [PATCH 01/42] Staging: add pcc-acpi driver
2008-10-23 2:49 ` [PATCH 01/42] Staging: add pcc-acpi driver Len Brown
@ 2008-10-23 4:55 ` Greg KH
2008-10-23 19:26 ` [GIT PATCH] delete pcc_acpi Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2008-10-23 4:55 UTC (permalink / raw)
To: Len Brown
Cc: Linux Kernel Mailing List, Hiroshi Miura, YOKOTA Hiroshi,
Harald Welte, linux-acpi
On Wed, Oct 22, 2008 at 10:49:26PM -0400, Len Brown wrote:
>
>
> On Wed, 22 Oct 2008, Greg KH wrote:
>
> > On Wed, Oct 22, 2008 at 02:37:18PM -0400, Len Brown wrote:
> > > NAK.
> > > this was already relplaced by the panasonic driver in the acpi tree.
> >
> > Is this in 2.6.27, or was it a 2.6.28 addition? For some reason, I had
> > reports from openSUSE users that 2.6.27 still didn't work properly and
> > needed this driver.
> >
> > How about the new "pcc-acpi-cdrom" driver hack? Hiroshi, is that needed
> > still with the 2.6.27 kernel?
>
> drivers/misc/panasonic-laptop.c is staged for 2.6.28:
>
> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=history;f=drivers/misc/panasonic-laptop.c;h=a2cb598d8ab54a98000d1f31f7c2407924399a5e;hb=test
Hm, we didn't get the acpi merge with Linus yet for .28? No wonder I
missed this, sorry about it.
> > > Greg,
> > > If it has the word "acpi" in it, please check with me before
> > > putting something in the staging tree, for I'd prefer to
> > > stage such things in the acpi tree.
> >
> > Ok, I didn't know you wanted "uncleaned" drivers in your tree, I'll
> > remember this for the future :)
>
> AFAICK, the driver that was checked into staging tree
> was based on an older version of the driver already staged
> in the acpi tree. I think that the staging tree
> isn't helping us in this scenario.
Fair enough, I'll drop it from my tree, thanks for paying attention and
letting me know.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PATCH] delete pcc_acpi
2008-10-23 2:49 ` [PATCH 01/42] Staging: add pcc-acpi driver Len Brown
2008-10-23 4:55 ` Greg KH
@ 2008-10-23 19:26 ` Len Brown
2008-10-23 20:22 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Len Brown @ 2008-10-23 19:26 UTC (permalink / raw)
To: Linus Torvalds
Cc: Linux Kernel Mailing List, Hiroshi Miura, YOKOTA Hiroshi,
Harald Welte, linux-acpi, Greg KH
Hi Linus,
please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release
this old driver errantly went upstream with the staging stuff, but should
not have.
This will update the files shown below.
thanks!
-Len
ps. individual patches are available on linux-acpi@vger.kernel.org
and a consolidated plain patch is available here:
ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/2.6.27/acpi-release-20080926-2.6.27.diff.gz
drivers/staging/Kconfig | 2 -
drivers/staging/Makefile | 1 -
drivers/staging/pcc-acpi/Kconfig | 11 -
drivers/staging/pcc-acpi/Makefile | 1 -
drivers/staging/pcc-acpi/TODO | 7 -
drivers/staging/pcc-acpi/pcc-acpi.c | 1111 -----------------------------------
6 files changed, 0 insertions(+), 1133 deletions(-)
delete mode 100644 drivers/staging/pcc-acpi/Kconfig
delete mode 100644 drivers/staging/pcc-acpi/Makefile
delete mode 100644 drivers/staging/pcc-acpi/TODO
delete mode 100644 drivers/staging/pcc-acpi/pcc-acpi.c
through these commits:
Len Brown (1):
staging: pcc_acpi: delete obsolete driver
with this log:
commit 0d64cf8eba6de467f56bc43c4d8e28b0e3e335c5
Author: Len Brown <len.brown@intel.com>
Date: Thu Oct 23 15:14:52 2008 -0400
staging: pcc_acpi: delete obsolete driver
pcc_acpi is based on an old version
of drivers/misc/panasonic-laptop.c
Signed-off-by: Len Brown <len.brown@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread