From: Thomas Renninger <trenn@suse.de>
To: miaox@cn.fujitsu.com
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c
Date: Fri, 24 Oct 2008 12:31:43 +0200 [thread overview]
Message-ID: <200810241231.44283.trenn@suse.de> (raw)
In-Reply-To: <490193BC.70108@cn.fujitsu.com>
On Friday 24 October 2008 11:22:04 Miao Xie wrote:
> When trying to build 2.6.28-rc1 on ia64, make aborts with:
>
> CC drivers/acpi/processor_perflib.o
> drivers/acpi/processor_perflib.c:41:28: error: asm/cpufeature.h: No such
> file or directory drivers/acpi/processor_perflib.c: In function
> ‘acpi_processor_get_performance_info’:
> drivers/acpi/processor_perflib.c:364: error: implicit declaration of
> function ‘boot_cpu_has’ drivers/acpi/processor_perflib.c:364: error:
> ‘X86_FEATURE_EST’ undeclared (first use in this function)
> drivers/acpi/processor_perflib.c:364: error: (Each undeclared identifier is
> reported only once drivers/acpi/processor_perflib.c:364: error: for each
> function it appears in.) make[2]: *** [drivers/acpi/processor_perflib.o]
> Error 1
> make[1]: *** [drivers/acpi] Error 2
> make: *** [drivers] Error 2
>
> this patch fix it.
Thanks.
Thomas
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> Cc: Thomas Renninger <trenn@suse.de>
>
> ---
> drivers/acpi/processor_perflib.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_perflib.c
> b/drivers/acpi/processor_perflib.c index dc98f7a..dbcf260 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -38,7 +38,10 @@
>
> #include <asm/uaccess.h>
> #endif
> +
> +#ifdef CONFIG_X86
> #include <asm/cpufeature.h>
> +#endif
>
> #include <acpi/acpi_bus.h>
> #include <acpi/processor.h>
> @@ -360,11 +363,13 @@ static int acpi_processor_get_performance_info(struct
> acpi_processor *pr) * the BIOS is older than the CPU and does not know its
> frequencies */
> update_bios:
> +#ifdef CONFIG_X86
> if (ACPI_SUCCESS(acpi_get_handle(pr->handle, "_PPC", &handle))){
> if(boot_cpu_has(X86_FEATURE_EST))
> printk(KERN_WARNING FW_BUG "BIOS needs update for CPU "
> "frequency support\n");
> }
> +#endif
> return result;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-24 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 9:22 [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c Miao Xie
2008-10-24 10:31 ` Thomas Renninger [this message]
2008-10-24 19:25 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810241231.44283.trenn@suse.de \
--to=trenn@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox