* [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c
@ 2008-10-24 9:22 Miao Xie
2008-10-24 10:31 ` Thomas Renninger
2008-10-24 19:25 ` Len Brown
0 siblings, 2 replies; 3+ messages in thread
From: Miao Xie @ 2008-10-24 9:22 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, trenn
When trying to build 2.6.28-rc1 on ia64, make aborts with:
CC drivers/acpi/processor_perflib.o
drivers/acpi/processor_perflib.c:41:28: error: asm/cpufeature.h: No such file or directory
drivers/acpi/processor_perflib.c: In function ‘acpi_processor_get_performance_info’:
drivers/acpi/processor_perflib.c:364: error: implicit declaration of function ‘boot_cpu_has’
drivers/acpi/processor_perflib.c:364: error: ‘X86_FEATURE_EST’ undeclared (first use in this function)
drivers/acpi/processor_perflib.c:364: error: (Each undeclared identifier is reported only once
drivers/acpi/processor_perflib.c:364: error: for each function it appears in.)
make[2]: *** [drivers/acpi/processor_perflib.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2
this patch fix it.
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Cc: Thomas Renninger <trenn@suse.de>
---
drivers/acpi/processor_perflib.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index dc98f7a..dbcf260 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -38,7 +38,10 @@
#include <asm/uaccess.h>
#endif
+
+#ifdef CONFIG_X86
#include <asm/cpufeature.h>
+#endif
#include <acpi/acpi_bus.h>
#include <acpi/processor.h>
@@ -360,11 +363,13 @@ static int acpi_processor_get_performance_info(struct acpi_processor *pr)
* the BIOS is older than the CPU and does not know its frequencies
*/
update_bios:
+#ifdef CONFIG_X86
if (ACPI_SUCCESS(acpi_get_handle(pr->handle, "_PPC", &handle))){
if(boot_cpu_has(X86_FEATURE_EST))
printk(KERN_WARNING FW_BUG "BIOS needs update for CPU "
"frequency support\n");
}
+#endif
return result;
}
--
1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c
2008-10-24 9:22 [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c Miao Xie
@ 2008-10-24 10:31 ` Thomas Renninger
2008-10-24 19:25 ` Len Brown
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Renninger @ 2008-10-24 10:31 UTC (permalink / raw)
To: miaox; +Cc: lenb, linux-acpi
On Friday 24 October 2008 11:22:04 Miao Xie wrote:
> When trying to build 2.6.28-rc1 on ia64, make aborts with:
>
> CC drivers/acpi/processor_perflib.o
> drivers/acpi/processor_perflib.c:41:28: error: asm/cpufeature.h: No such
> file or directory drivers/acpi/processor_perflib.c: In function
> ‘acpi_processor_get_performance_info’:
> drivers/acpi/processor_perflib.c:364: error: implicit declaration of
> function ‘boot_cpu_has’ drivers/acpi/processor_perflib.c:364: error:
> ‘X86_FEATURE_EST’ undeclared (first use in this function)
> drivers/acpi/processor_perflib.c:364: error: (Each undeclared identifier is
> reported only once drivers/acpi/processor_perflib.c:364: error: for each
> function it appears in.) make[2]: *** [drivers/acpi/processor_perflib.o]
> Error 1
> make[1]: *** [drivers/acpi] Error 2
> make: *** [drivers] Error 2
>
> this patch fix it.
Thanks.
Thomas
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> Cc: Thomas Renninger <trenn@suse.de>
>
> ---
> drivers/acpi/processor_perflib.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_perflib.c
> b/drivers/acpi/processor_perflib.c index dc98f7a..dbcf260 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -38,7 +38,10 @@
>
> #include <asm/uaccess.h>
> #endif
> +
> +#ifdef CONFIG_X86
> #include <asm/cpufeature.h>
> +#endif
>
> #include <acpi/acpi_bus.h>
> #include <acpi/processor.h>
> @@ -360,11 +363,13 @@ static int acpi_processor_get_performance_info(struct
> acpi_processor *pr) * the BIOS is older than the CPU and does not know its
> frequencies */
> update_bios:
> +#ifdef CONFIG_X86
> if (ACPI_SUCCESS(acpi_get_handle(pr->handle, "_PPC", &handle))){
> if(boot_cpu_has(X86_FEATURE_EST))
> printk(KERN_WARNING FW_BUG "BIOS needs update for CPU "
> "frequency support\n");
> }
> +#endif
> return result;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c
2008-10-24 9:22 [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c Miao Xie
2008-10-24 10:31 ` Thomas Renninger
@ 2008-10-24 19:25 ` Len Brown
1 sibling, 0 replies; 3+ messages in thread
From: Len Brown @ 2008-10-24 19:25 UTC (permalink / raw)
To: Miao Xie; +Cc: linux-acpi, trenn, linux-ia64
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2202 bytes --]
applied.
thanks,
-len
On Fri, 24 Oct 2008, Miao Xie wrote:
> When trying to build 2.6.28-rc1 on ia64, make aborts with:
>
> CC drivers/acpi/processor_perflib.o
> drivers/acpi/processor_perflib.c:41:28: error: asm/cpufeature.h: No such file or directory
> drivers/acpi/processor_perflib.c: In function ‘acpi_processor_get_performance_info’:
> drivers/acpi/processor_perflib.c:364: error: implicit declaration of function ‘boot_cpu_has’
> drivers/acpi/processor_perflib.c:364: error: ‘X86_FEATURE_EST’ undeclared (first use in this function)
> drivers/acpi/processor_perflib.c:364: error: (Each undeclared identifier is reported only once
> drivers/acpi/processor_perflib.c:364: error: for each function it appears in.)
> make[2]: *** [drivers/acpi/processor_perflib.o] Error 1
> make[1]: *** [drivers/acpi] Error 2
> make: *** [drivers] Error 2
>
> this patch fix it.
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
> Cc: Thomas Renninger <trenn@suse.de>
>
> ---
> drivers/acpi/processor_perflib.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
> index dc98f7a..dbcf260 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -38,7 +38,10 @@
>
> #include <asm/uaccess.h>
> #endif
> +
> +#ifdef CONFIG_X86
> #include <asm/cpufeature.h>
> +#endif
>
> #include <acpi/acpi_bus.h>
> #include <acpi/processor.h>
> @@ -360,11 +363,13 @@ static int acpi_processor_get_performance_info(struct acpi_processor *pr)
> * the BIOS is older than the CPU and does not know its frequencies
> */
> update_bios:
> +#ifdef CONFIG_X86
> if (ACPI_SUCCESS(acpi_get_handle(pr->handle, "_PPC", &handle))){
> if(boot_cpu_has(X86_FEATURE_EST))
> printk(KERN_WARNING FW_BUG "BIOS needs update for CPU "
> "frequency support\n");
> }
> +#endif
> return result;
> }
>
> --
> 1.5.4.rc3
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-24 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-24 9:22 [PATCH] ACPI: cpufreq, processor: fix compile error in drivers/acpi/processor_perflib.c Miao Xie
2008-10-24 10:31 ` Thomas Renninger
2008-10-24 19:25 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox