From: Andrew Patterson <andrew.patterson@hp.com>
To: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: andrew.patterson@hp.com, matthew@wil.cx
Subject: [PATCH 7/8] PCI: check if MSI is enabled before adding _OSC support capability
Date: Tue, 28 Oct 2008 23:48:51 -0600 [thread overview]
Message-ID: <20081029054851.2263.36283.stgit@bob.kio> (raw)
In-Reply-To: <20081029054815.2263.40833.stgit@bob.kio>
PCI: check if MSI is enabled before adding _OSC support capability
Ensure that pci=nomsi is not set before adding the _OSC support capability
OSC_MSI_SUPPORT to the root bridge.
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
---
drivers/acpi/pci_root.c | 20 +++++++++++---------
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 75a59ea..32afd02 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -194,6 +194,7 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
unsigned long long value = 0;
acpi_handle handle = NULL;
struct acpi_device *child;
+ u32 flags;
if (!device)
@@ -211,17 +212,18 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
device->ops.bind = acpi_pci_bind;
- pci_acpi_osc_support(device->handle,
- OSC_EXT_PCI_CONFIG_SUPPORT |
- OSC_PCI_SEGMENT_GROUPS_SUPPORT |
-#ifdef CONFIG_PCI_MSI
- OSC_MSI_SUPPORT |
-#endif
+ flags = (OSC_EXT_PCI_CONFIG_SUPPORT |
+ OSC_PCI_SEGMENT_GROUPS_SUPPORT |
#ifdef CONFIG_PCIEASPM
- OSC_ACTIVE_STATE_PWR_SUPPORT |
- OSC_CLOCK_PWR_CAPABILITY_SUPPORT |
+ OSC_ACTIVE_STATE_PWR_SUPPORT |
+ OSC_CLOCK_PWR_CAPABILITY_SUPPORT |
+#endif
+ 0);
+#ifdef CONFIG_PCI_MSI
+ if (pci_msi_enabled())
+ flags |= OSC_MSI_SUPPORT;
#endif
- 0);
+ pci_acpi_osc_support(device->handle, flags);
/*
* Segment
next prev parent reply other threads:[~2008-10-29 5:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 5:48 [PATCH 0/8] call _OSC support during root bridge discovery Andrew Patterson
2008-10-29 5:48 ` [PATCH 1/8] PCI, ACPI: include missing acpi.h file in pci-acpi.h Andrew Patterson
2008-10-29 5:48 ` [PATCH 2/8] ACPI, PCI: call _OSC support during root bridge discovery Andrew Patterson
2008-10-29 14:30 ` Bjorn Helgaas
2008-10-29 20:28 ` Andrew Patterson
2008-10-29 5:48 ` [PATCH 3/8] ACPI, PCI: PCIe ASPM _OSC support capabilities called when root bridge added Andrew Patterson
2008-10-29 6:06 ` Kenji Kaneshige
2008-10-29 16:19 ` Andrew Patterson
2008-10-29 22:57 ` Andrew Patterson
2008-10-29 5:48 ` [PATCH 4/8] ACPI, PCI: PCIe AER " Andrew Patterson
2008-10-29 5:48 ` [PATCH 5/8] ACPI, PCI: PCI MSI " Andrew Patterson
2008-10-29 5:48 ` [PATCH 6/8] PCI: added pci_msi_enabled which checks for pci=nomsi Andrew Patterson
2008-10-29 14:33 ` Bjorn Helgaas
2008-10-29 21:36 ` Andrew Patterson
2008-10-29 5:48 ` Andrew Patterson [this message]
2008-10-29 6:19 ` [PATCH 7/8] PCI: check if MSI is enabled before adding _OSC support capability Kenji Kaneshige
2008-10-30 4:51 ` Andrew Patterson
2008-10-29 14:33 ` Bjorn Helgaas
2008-10-29 21:57 ` Andrew Patterson
2008-10-29 5:48 ` [PATCH 8/8] PCI, ACPI: remove obsolete _OSC capability support functions Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029054851.2263.36283.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox