public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/3] fujitsu-laptop: fix section mismatch warning
@ 2008-10-29 21:13 akpm
  2008-11-07  2:42 ` Len Brown
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-10-29 21:13 UTC (permalink / raw)
  To: lenb; +Cc: linux-acpi, akpm, randy.dunlap, jwoithe

From: Randy Dunlap <randy.dunlap@oracle.com>

Could fix a bug in a hotplug add scenario.

WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table
The function acpi_fujitsu_add() references
the variable __initdata fujitsu_dmi_table.
This is often because acpi_fujitsu_add lacks a __initdata
annotation or the annotation of fujitsu_dmi_table is wrong.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/misc/fujitsu-laptop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/misc/fujitsu-laptop.c~fujitsu-laptop-fix-section-mismatch-warning drivers/misc/fujitsu-laptop.c
--- a/drivers/misc/fujitsu-laptop.c~fujitsu-laptop-fix-section-mismatch-warning
+++ a/drivers/misc/fujitsu-laptop.c
@@ -473,7 +473,7 @@ static int dmi_check_cb_p8010(const stru
 	return 0;
 }
 
-static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
+static struct dmi_system_id fujitsu_dmi_table[] = {
 	{
 	 .ident = "Fujitsu Siemens S6410",
 	 .matches = {
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/3] fujitsu-laptop: fix section mismatch warning
  2008-10-29 21:13 [patch 1/3] fujitsu-laptop: fix section mismatch warning akpm
@ 2008-11-07  2:42 ` Len Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2008-11-07  2:42 UTC (permalink / raw)
  To: akpm; +Cc: linux-acpi, randy.dunlap, jwoithe

applied.

thanks,
-len

On Wed, 29 Oct 2008, akpm@linux-foundation.org wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Could fix a bug in a hotplug add scenario.
> 
> WARNING: drivers/misc/fujitsu-laptop.o(.text+0xbde): Section mismatch in reference from the function acpi_fujitsu_add() to the variable .init.data:fujitsu_dmi_table
> The function acpi_fujitsu_add() references
> the variable __initdata fujitsu_dmi_table.
> This is often because acpi_fujitsu_add lacks a __initdata
> annotation or the annotation of fujitsu_dmi_table is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/misc/fujitsu-laptop.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/misc/fujitsu-laptop.c~fujitsu-laptop-fix-section-mismatch-warning drivers/misc/fujitsu-laptop.c
> --- a/drivers/misc/fujitsu-laptop.c~fujitsu-laptop-fix-section-mismatch-warning
> +++ a/drivers/misc/fujitsu-laptop.c
> @@ -473,7 +473,7 @@ static int dmi_check_cb_p8010(const stru
>  	return 0;
>  }
>  
> -static struct dmi_system_id __initdata fujitsu_dmi_table[] = {
> +static struct dmi_system_id fujitsu_dmi_table[] = {
>  	{
>  	 .ident = "Fujitsu Siemens S6410",
>  	 .matches = {
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-07  2:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 21:13 [patch 1/3] fujitsu-laptop: fix section mismatch warning akpm
2008-11-07  2:42 ` Len Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox