From: Andrew Patterson <andrew.patterson@hp.com>
To: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: andrew.patterson@hp.com, matthew@wil.cx,
kaneshige.kenji@jp.fujitsu.com, bjorn.helgaas@hp.com
Subject: [PATCH 3/6] ACPI, PCI: PCIe ASPM _OSC support capabilities called when root bridge added
Date: Wed, 29 Oct 2008 23:28:02 -0600 [thread overview]
Message-ID: <20081030052802.10259.16214.stgit@bob.kio> (raw)
In-Reply-To: <20081030052746.10259.22045.stgit@bob.kio>
ACPI, PCI: PCIe ASPM _OSC support capabilities called when root bridge added
The _OSC capabilities OSC_ACTIVE_STATE_PWR_SUPPORT and
OSC_CLOCK_PWR_CAPABILITY_SUPPORT are set when the root bridge is added
with pci_acpi_osc_support(), so we no longer need to do it in the
ASPM driver.
Added the function pcie_aspm_enabled, which returns true if pcie_aspm=off
is not on the kernel command-line.
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
---
drivers/acpi/pci_root.c | 3 +++
drivers/pci/pcie/aspm.c | 27 +++++++++------------------
include/linux/pci.h | 9 +++++++++
3 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index b4d55f2..c36dc1d 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -215,6 +215,9 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
flags = (OSC_EXT_PCI_CONFIG_SUPPORT |
OSC_PCI_SEGMENT_GROUPS_SUPPORT |
0);
+ if (pcie_aspm_enabled())
+ flags |= OSC_ACTIVE_STATE_PWR_SUPPORT |
+ OSC_CLOCK_PWR_CAPABILITY_SUPPORT;
pci_acpi_osc_support(device->handle, flags);
/*
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 8f63f4c..1089f86 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -834,24 +834,15 @@ void pcie_no_aspm(void)
aspm_disabled = 1;
}
-#ifdef CONFIG_ACPI
-#include <acpi/acpi_bus.h>
-#include <linux/pci-acpi.h>
-static void pcie_aspm_platform_init(void)
-{
- pcie_osc_support_set(OSC_ACTIVE_STATE_PWR_SUPPORT|
- OSC_CLOCK_PWR_CAPABILITY_SUPPORT);
-}
-#else
-static inline void pcie_aspm_platform_init(void) { }
-#endif
-
-static int __init pcie_aspm_init(void)
+/**
+ * pcie_aspm_enabled - is PCIe ASPM enabled?
+ *
+ * Returns true if ASPM has not been disabled by the command-line option
+ * pcie_aspm=off.
+ **/
+int pcie_aspm_enabled(void)
{
- if (aspm_disabled)
- return 0;
- pcie_aspm_platform_init();
- return 0;
+ return !aspm_disabled;
}
+EXPORT_SYMBOL(pcie_aspm_enabled);
-fs_initcall(pcie_aspm_init);
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 752def8..682033c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -779,6 +779,15 @@ extern void msi_remove_pci_irq_vectors(struct pci_dev *dev);
extern void pci_restore_msi_state(struct pci_dev *dev);
#endif
+#ifndef CONFIG_PCIEASPM
+static inline int pcie_aspm_enabled(void)
+{
+ return 0;
+}
+#else
+extern int pcie_aspm_enabled(void);
+#endif
+
#ifdef CONFIG_HT_IRQ
/* The functions a driver should call */
int ht_create_irq(struct pci_dev *dev, int idx);
next prev parent reply other threads:[~2008-10-30 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 5:27 [PATCH v2 0/6] call _OSC support during root bridge discovery Andrew Patterson
2008-10-30 5:27 ` [PATCH 1/6] PCI, ACPI: include missing acpi.h file in pci-acpi.h Andrew Patterson
2008-10-30 5:27 ` [PATCH 2/6] ACPI, PCI: call _OSC support during root bridge discovery Andrew Patterson
2008-10-30 5:28 ` Andrew Patterson [this message]
2008-10-30 5:28 ` [PATCH 4/6] ACPI, PCI: PCIe AER _OSC support capabilities called when root bridge added Andrew Patterson
2008-10-30 5:28 ` [PATCH 5/6] ACPI, PCI: PCI MSI " Andrew Patterson
2008-10-30 5:28 ` [PATCH 6/6] PCI, ACPI: remove obsolete _OSC capability support functions Andrew Patterson
2008-10-30 9:08 ` [PATCH v2 0/6] call _OSC support during root bridge discovery Kenji Kaneshige
2008-10-31 16:28 ` Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030052802.10259.16214.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox