From: Andrew Patterson <andrew.patterson@hp.com>
To: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: andrew.patterson@hp.com, matthew@wil.cx,
kaneshige.kenji@jp.fujitsu.com, bjorn.helgaas@hp.com
Subject: [PATCH 3/7] ACPI, PCI: PCI extended config _OSC support called when root bridge added
Date: Tue, 04 Nov 2008 22:29:50 -0700 [thread overview]
Message-ID: <20081105052950.15722.94409.stgit@bob.kio> (raw)
In-Reply-To: <20081105052934.15722.98580.stgit@bob.kio>
ACPI, PCI: PCI extended config _OSC support called when root bridge added
The _OSC capability OSC_EXT_PCI_CONFIG_SUPPORT is set when the root bridge
is added with pci_acpi_osc_support() if we can access PCI extended
config space.
Added the function pci_no_mmcfg_enabled which sets the variable
pci_mmcfg_disabled=1 if pci=nommconf is included on the kernel command-
line.
Added the function pci_ext_cfg_avail which returns true if we can
access PCI extended config space (offset greater than 0xff). It
currently only returns false if pci=nommconf is included on the kernel
command-line.
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
---
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index b67732b..e714976 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -470,6 +470,7 @@ char * __devinit pcibios_setup(char *str)
#endif
#ifdef CONFIG_PCI_MMCONFIG
else if (!strcmp(str, "nommconf")) {
+ pci_no_mmcfg();
pci_probe &= ~PCI_PROBE_MMCONF;
return NULL;
}
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index e1cf2b7..1fcf40f 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -212,8 +212,9 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device)
device->ops.bind = acpi_pci_bind;
- flags = (OSC_PCI_SEGMENT_GROUPS_SUPPORT |
- 0);
+ flags = OSC_PCI_SEGMENT_GROUPS_SUPPORT;
+ if (pci_ext_cfg_avail())
+ flags |= OSC_EXT_PCI_CONFIG_SUPPORT;
pci_acpi_osc_support(device->handle, flags);
/*
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 21f2ac6..c22a31d 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -28,6 +28,10 @@ unsigned int pci_pm_d3_delay = 10;
int pci_domains_supported = 1;
#endif
+#ifdef CONFIG_PCI_MMCONFIG
+static int pci_mmcfg_disabled;
+#endif
+
#define DEFAULT_CARDBUS_IO_SIZE (256)
#define DEFAULT_CARDBUS_MEM_SIZE (64*1024*1024)
/* pci=cbmemsize=nnM,cbiosize=nn can override this */
@@ -2029,6 +2033,28 @@ static void __devinit pci_no_domains(void)
#endif
}
+#ifdef CONFIG_PCI_MMCONFIG
+void pci_no_mmcfg(void)
+{
+ pci_mmcfg_disabled = 1;
+}
+#endif
+
+/**
+ * pci_ext_cfg_enabled - can we access extended PCI config space?
+ *
+ * Returns true if we can access PCI extended config space (offsets greater
+ * than 0xff).
+ */
+int pci_ext_cfg_avail(void)
+{
+#ifdef CONFIG_PCI_MMCONFIG
+ if (pci_mmcfg_disabled)
+ return 0;
+#endif
+ return 1;
+}
+
static int __devinit pci_init(void)
{
struct pci_dev *dev = NULL;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c75b82b..ea2fb2b 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1130,11 +1130,15 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev,
#ifdef CONFIG_PCI_MMCONFIG
extern void __init pci_mmcfg_early_init(void);
extern void __init pci_mmcfg_late_init(void);
+void pci_no_mmcfg(void);
#else
static inline void pci_mmcfg_early_init(void) { }
static inline void pci_mmcfg_late_init(void) { }
+static inline void pci_no_mmcfg(void) { }
#endif
+int pci_ext_cfg_avail(void);
+
#ifdef CONFIG_HAS_IOMEM
static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
{
next prev parent reply other threads:[~2008-11-05 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 5:29 [PATCH v3 0/7] call _OSC support during root bridge discovery Andrew Patterson
2008-11-05 5:29 ` [PATCH 1/7] PCI, ACPI: include missing acpi.h file in pci-acpi.h Andrew Patterson
2008-11-05 5:29 ` [PATCH 2/7] ACPI, PCI: call _OSC support during root bridge discovery Andrew Patterson
2008-11-05 5:29 ` Andrew Patterson [this message]
2008-11-05 5:29 ` [PATCH 4/7] ACPI, PCI: PCIe ASPM _OSC support capabilities called when root bridge added Andrew Patterson
2008-11-05 5:30 ` [PATCH 5/7] ACPI, PCI: PCIe AER " Andrew Patterson
2008-11-05 5:30 ` [PATCH 6/7] ACPI, PCI: PCI MSI " Andrew Patterson
2008-11-05 5:30 ` [PATCH 7/7] PCI, ACPI: remove obsolete _OSC capability support functions Andrew Patterson
-- strict thread matches above, loose matches on Subject: below --
2008-11-10 22:30 [PATCH v4 0/7] call _OSC support during root bridge discovery Andrew Patterson
2008-11-10 22:30 ` [PATCH 3/7] ACPI, PCI: PCI extended config _OSC support called when root bridge added Andrew Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105052950.15722.94409.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox