From: Andrew Patterson <andrew.patterson@hp.com>
To: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: andrew.patterson@hp.com, matthew@wil.cx,
kaneshige.kenji@jp.fujitsu.com, bjorn.helgaas@hp.com
Subject: [PATCH 7/7] PCI, ACPI: remove obsolete _OSC capability support functions
Date: Tue, 04 Nov 2008 22:30:10 -0700 [thread overview]
Message-ID: <20081105053010.15722.69142.stgit@bob.kio> (raw)
In-Reply-To: <20081105052934.15722.98580.stgit@bob.kio>
PCI, ACPI: remove obsolete _OSC capability support functions
The acpi_query_osc, __pci_osc_support_set, pci_osc_support_set, and
pcie_osc_support_set functions have been obsoleted in favor of setting
these capabilities during root bridge discovery with pci_acpi_osc_support.
There are no longer any callers of these functions, so they are removed.
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
---
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index f457387..128ce7d 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -171,31 +171,6 @@ out:
return rc;
}
-static acpi_status acpi_query_osc(acpi_handle handle, u32 level,
- void *context, void **retval)
-{
- pci_acpi_osc_support(handle, (unsigned long)context);
- return AE_OK;
-}
-
-/**
- * __pci_osc_support_set - register OS support to Firmware
- * @flags: OS support bits
- * @hid: hardware ID
- *
- * Update OS support fields and doing a _OSC Query to obtain an update
- * from Firmware on supported control bits.
- **/
-acpi_status __pci_osc_support_set(u32 flags, const char *hid)
-{
- if (!(flags & OSC_SUPPORT_MASKS))
- return AE_TYPE;
-
- acpi_get_devices(hid, acpi_query_osc,
- (void *)(unsigned long)flags, NULL);
- return AE_OK;
-}
-
/**
* pci_osc_control_set - commit requested control to Firmware
* @handle: acpi_handle for the target ACPI object
diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h
index 424f06f..871e096 100644
--- a/include/linux/pci-acpi.h
+++ b/include/linux/pci-acpi.h
@@ -50,16 +50,7 @@
#ifdef CONFIG_ACPI
extern acpi_status pci_osc_control_set(acpi_handle handle, u32 flags);
-extern acpi_status __pci_osc_support_set(u32 flags, const char *hid);
int pci_acpi_osc_support(acpi_handle handle, u32 flags);
-static inline acpi_status pci_osc_support_set(u32 flags)
-{
- return __pci_osc_support_set(flags, PCI_ROOT_HID_STRING);
-}
-static inline acpi_status pcie_osc_support_set(u32 flags)
-{
- return __pci_osc_support_set(flags, PCI_EXPRESS_ROOT_HID_STRING);
-}
static inline acpi_handle acpi_find_root_bridge_handle(struct pci_dev *pdev)
{
/* Find root host bridge */
@@ -76,8 +67,6 @@ typedef u32 acpi_status;
#endif
static inline acpi_status pci_osc_control_set(acpi_handle handle, u32 flags)
{return AE_ERROR;}
-static inline acpi_status pci_osc_support_set(u32 flags) {return AE_ERROR;}
-static inline acpi_status pcie_osc_support_set(u32 flags) {return AE_ERROR;}
static inline acpi_handle acpi_find_root_bridge_handle(struct pci_dev *pdev)
{ return NULL; }
#endif
next prev parent reply other threads:[~2008-11-05 5:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 5:29 [PATCH v3 0/7] call _OSC support during root bridge discovery Andrew Patterson
2008-11-05 5:29 ` [PATCH 1/7] PCI, ACPI: include missing acpi.h file in pci-acpi.h Andrew Patterson
2008-11-05 5:29 ` [PATCH 2/7] ACPI, PCI: call _OSC support during root bridge discovery Andrew Patterson
2008-11-05 5:29 ` [PATCH 3/7] ACPI, PCI: PCI extended config _OSC support called when root bridge added Andrew Patterson
2008-11-05 5:29 ` [PATCH 4/7] ACPI, PCI: PCIe ASPM _OSC support capabilities " Andrew Patterson
2008-11-05 5:30 ` [PATCH 5/7] ACPI, PCI: PCIe AER " Andrew Patterson
2008-11-05 5:30 ` [PATCH 6/7] ACPI, PCI: PCI MSI " Andrew Patterson
2008-11-05 5:30 ` Andrew Patterson [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-10 22:30 [PATCH v4 0/7] call _OSC support during root bridge discovery Andrew Patterson
2008-11-10 22:31 ` [PATCH 7/7] PCI, ACPI: remove obsolete _OSC capability support functions Andrew Patterson
2008-11-12 21:15 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105053010.15722.69142.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox