[PATCH]1/3 intel_menlow:Adding comment for GTHS legal values

[PATCH]1/3 intel_menlow:Adding comment for GTHS legal values

[Thomas, Sujith]

Documentation of legal values for GTHS
To be patched over Rui's 09/11 bug fix patch

Signed-off-by: Sujith Thomas <sujith.thomas@intel.com>
---
 drivers/misc/intel_menlow.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux-2.6.27/drivers/misc/intel_menlow.c
===================================================================
--- linux-2.6.27.orig/drivers/misc/intel_menlow.c
+++ linux-2.6.27/drivers/misc/intel_menlow.c
@@ -52,6 +52,11 @@ MODULE_LICENSE("GPL");
 #define MEMORY_ARG_CUR_BANDWIDTH 1
 #define MEMORY_ARG_MAX_BANDWIDTH 0
 
+/*
+ * GTHS returning 'n' would mean that [0,n-1] states are supported
+ * In that case max_cstate would be n-1
+ * GTHS returning '0' would mean that no bandwidth control states are
supported
+ */
 static int memory_get_int_max_bandwidth(struct thermal_cooling_device
*cdev,
 					unsigned long *max_state)
 {

Re: [PATCH]1/3 intel_menlow:Adding comment for GTHS legal values

[Andrew Morton]

On Wed, 5 Nov 2008 16:15:13 +0530
"Thomas, Sujith" <sujith.thomas@intel.com> wrote:

> Subject: [PATCH]1/3 intel_menlow:Adding comment for GTHS legal values

Please put the "1/3" inside the square brackets.  Because that
numbering is only relevant for this series of emails and should be
stripped out when the patch is merged into another tree.  The way in
which we tell the recipient about text which they should strip out is
to put it in square brackets.

Please put a space after colons.

> Date: Wed, 5 Nov 2008 16:15:13 +0530
> 
> Documentation of legal values for GTHS
> To be patched over Rui's 09/11 bug fix patch
> 
> Signed-off-by: Sujith Thomas <sujith.thomas@intel.com>
> ---
>  drivers/misc/intel_menlow.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> Index: linux-2.6.27/drivers/misc/intel_menlow.c
> ===================================================================
> --- linux-2.6.27.orig/drivers/misc/intel_menlow.c
> +++ linux-2.6.27/drivers/misc/intel_menlow.c
> @@ -52,6 +52,11 @@ MODULE_LICENSE("GPL");
>  #define MEMORY_ARG_CUR_BANDWIDTH 1
>  #define MEMORY_ARG_MAX_BANDWIDTH 0
>  
> +/*
> + * GTHS returning 'n' would mean that [0,n-1] states are supported
> + * In that case max_cstate would be n-1
> + * GTHS returning '0' would mean that no bandwidth control states are
> supported
> + */
>  static int memory_get_int_max_bandwidth(struct thermal_cooling_device
> *cdev,

The patches were quite badly wordwrapped by your email client.

Re: [PATCH]1/3 intel_menlow:Adding comment for GTHS legal values

[Len Brown]

Hi Sujith,

I applied 1/3 and 2/3.
I had to hand-edit them because they were line wrapped
by your mailer.

This is only a minor waste of my time for a trivial patch,
but for a longer patch, I'm not going to do that for you.

Please read Documentation/SubmittingPatches

note that it is [PATCH 1/3], not [PATCH] 1/3 -- as future
generations don't need the '1/3' in the commit message...

thanks,
-Len

ps. also, don't bother sending a copy of patches to my intel.com
address, that goes to exchange, which destroys patches.
I apply all patches from my kernel.org account, which is
subscribed to the lists.

On Wed, 5 Nov 2008, Thomas, Sujith wrote:

> Documentation of legal values for GTHS
> To be patched over Rui's 09/11 bug fix patch
> 
> Signed-off-by: Sujith Thomas <sujith.thomas@intel.com>
> ---
>  drivers/misc/intel_menlow.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> Index: linux-2.6.27/drivers/misc/intel_menlow.c
> ===================================================================
> --- linux-2.6.27.orig/drivers/misc/intel_menlow.c
> +++ linux-2.6.27/drivers/misc/intel_menlow.c
> @@ -52,6 +52,11 @@ MODULE_LICENSE("GPL");
>  #define MEMORY_ARG_CUR_BANDWIDTH 1
>  #define MEMORY_ARG_MAX_BANDWIDTH 0
>  
> +/*
> + * GTHS returning 'n' would mean that [0,n-1] states are supported
> + * In that case max_cstate would be n-1
> + * GTHS returning '0' would mean that no bandwidth control states are
> supported
> + */
>  static int memory_get_int_max_bandwidth(struct thermal_cooling_device
> *cdev,
>  					unsigned long *max_state)
>  {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>