From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, Thomas Renninger <trenn@suse.de>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: [PATCH 4/5] ACPI: turn off all debug output by default
Date: Fri, 07 Nov 2008 16:58:00 -0700 [thread overview]
Message-ID: <20081107235800.32050.4699.stgit@bob.kio> (raw)
In-Reply-To: <20081107235644.32050.74757.stgit@bob.kio>
When CONFIG_ACPI_DEBUG=y, the default acpi_dbg_layer and acpi_dbg_level
values built into the ACPI CA have some debug output enabled. We'd
rather be quiet unless the user actually specified the acpi.debug_level
argument.
This enables distros to ship with CONFIG_ACPI_DEBUG=y without
inundating users with debug output.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/acpi/bus.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index c797c64..0ae9e3c 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -688,6 +688,14 @@ void __init acpi_early_init(void)
if (acpi_disabled)
return;
+ /*
+ * ACPI CA initializes acpi_dbg_level to non-zero, which means
+ * we get debug output merely by turning on CONFIG_ACPI_DEBUG.
+ * Turn it off so we don't get output unless the user specifies
+ * acpi.debug_level.
+ */
+ acpi_dbg_level = 0;
+
printk(KERN_INFO PREFIX "Core revision %08x\n", ACPI_CA_VERSION);
/* enable workarounds, unless strict ACPI spec. compliance */
next prev parent reply other threads:[~2008-11-07 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 23:57 [PATCH 0/5] ACPI: debug cleanup and documentation Bjorn Helgaas
2008-11-07 23:57 ` [PATCH 1/5] ACPI: consolidate ACPI_*_COMPONENT definitions in acpi_drivers.h Bjorn Helgaas
2008-11-07 23:57 ` [PATCH 2/5] ACPI: fix conflicting component definitions Bjorn Helgaas
2008-11-07 23:57 ` [PATCH 3/5] ACPI: add driver component definitions to sysfs debug_layers Bjorn Helgaas
2008-11-07 23:58 ` Bjorn Helgaas [this message]
2008-11-07 23:58 ` [PATCH 5/5] ACPI: update debug parameter documentation Bjorn Helgaas
2008-11-08 2:46 ` [PATCH 0/5] ACPI: debug cleanup and documentation Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107235800.32050.4699.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox