Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)

Matthew Garrett
2008-11-12T00:28:05Z

On Tue, Nov 11, 2008 at 06:14:31PM -0500, Len Brown wrote:
> On Mon, 10 Nov 2008, Matthew Garrett wrote:
> > All we need now is confirmation as to which versions of Windows use this
> > behaviour.
>
> We knows XP and Vista do it.

How would you feel about having a global variable bitfield containing
the operating systems the firmware queries, and then keying decisions
like this off that?

> But upstream doesn't currently check the FADT.flags.reset-reg-supported bit
> due to a recent bad guess on my part on how to be bug compatible with
> windows.

Mm. Getting that right is probably important, as is trying to figure out
why we break on certain machines in that case. Is it possible that going
via the keyboad controller tends to cause an implicit reset in it that's
not mimiced by the i8042 shutdown code?

--
Matthew Garrett | mjg59@srcf.ucam.org