Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)

Avi Kivity
2008-11-12T12:23:59Z

Ingo Molnar wrote:
>>
>> We knows XP and Vista do it.
>>
>> But upstream doesn't currently check the FADT.flags.reset-reg-supported bit
>> due to a recent bad guess on my part on how to be bug compatible with
>> windows.
>>
>> The (revert) patch to add that check is in my tree, along with
>> the trivial patch to flip the default to acpi-reset.
>>
>> Technically, that is the only "unanced" thing we should need
>> to check. However, it will not fix Avi's box, where it appears
>> that flag is present, the reset works, but for some reason the
>> keyboard fails after reset. More likely that is a device driver
>> issue specific to Linux interacting with "unexpected" BIOS behavior.
>>
>
> hm, will that also fix Andrey's box?
>

This describes Andrey's box, not mine. Mine (and others) have working
acpi reset and non-working keyboard reset; so reset was done using
triple-fault which fails when virtualization is enabled.

--
error compiling committee.c: too many arguments to function