Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)

Andrey Borzenkov
2008-11-08T06:30:33Z

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

On Saturday 08 November 2008, Len Brown wrote:
>
> > > -enum reboot_type reboot_type = BOOT_KBD;
> > > +enum reboot_type reboot_type = BOOT_ACPI;
>
> > NAK.
> >
> > Your point that the set of systems where KBD-reboot is broken is
> > larger (and growing) than the set of systems where ACPI-reboot is
> > broken (which set probably has a constant size) is true.
> >
> > But still this change caused non-trivial regressions in v28 _worse_
> > than the inability to reboot cleanly, so this patch does not fly as-is
> > as we reverted it upstream for a good reason.
>
> If you can direct me to the failures that ACPI reset caused
> in 28, that would be great.

http://marc.info/?l=linux-kernel&m=122547719810921&w=2

> Obviously they are not on
> the linux-acpi archives because the x86 tree enabled
> ACPI reset and then disabled it w/o telling us...
>
> thanks,
> -Len
>
>

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]