Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)

Avi Kivity
2008-11-09T09:55:50Z

Ingo Molnar wrote:
> Len, please consider my Lenovo T60 laptop "possibly affected" too. I
> was seeing weird sporadic reboot hangs which went away roughly since
> around that revert.
>
>

Given that Windows uses ACPI reboot, I find it unlikely that it is so
unreliable. Maybe some other problem in the tree got fixed?

> So the negative scope of the change, even after such short amount of
> testing, is non-trivial, and we simply have to go via a flag day date
> approach. Or, if these bugs are debuggable, make the ACPI reboot
> sequence more reliable.

I think the sequence should be acpi -> kbd -> triple fault. Given that
Windows uses ACPI, the number of machines that support it is much larger
(and growing daily) than the number of machines that do not.

--
error compiling committee.c: too many arguments to function