From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, Thomas Renninger <trenn@suse.de>
Subject: [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality
Date: Sat, 8 Nov 2008 16:37:44 +0300 [thread overview]
Message-ID: <200811081637.45099.arvidjaar@mail.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]
Subject: [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality
From: Andrey Borzenkov <arvidjaar@mail.ru>
Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
---
This completes backlight series; toshiba_acpi was missing.
drivers/acpi/toshiba_acpi.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/toshiba_acpi.c b/drivers/acpi/toshiba_acpi.c
index a7db0c2..c140709 100644
--- a/drivers/acpi/toshiba_acpi.c
+++ b/drivers/acpi/toshiba_acpi.c
@@ -780,19 +780,20 @@ static int __init toshiba_acpi_init(void)
}
}
- toshiba_backlight_device = backlight_device_register("toshiba",
+ if (!acpi_video_backlight_support()) {
+ toshiba_backlight_device = backlight_device_register("toshiba",
&toshiba_acpi.p_dev->dev,
NULL,
&toshiba_backlight_data);
- if (IS_ERR(toshiba_backlight_device)) {
- ret = PTR_ERR(toshiba_backlight_device);
-
- printk(KERN_ERR "Could not register toshiba backlight device\n");
- toshiba_backlight_device = NULL;
- toshiba_acpi_exit();
- return ret;
+ if (IS_ERR(toshiba_backlight_device)) {
+ ret = PTR_ERR(toshiba_backlight_device);
+ printk(KERN_ERR "Could not register toshiba backlight device\n");
+ toshiba_backlight_device = NULL;
+ toshiba_acpi_exit();
+ return ret;
+ }
+ toshiba_backlight_device->props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1;
}
- toshiba_backlight_device->props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1;
/* Register rfkill switch for Bluetooth */
if (hci_get_bt_present(&bt_present) == HCI_SUCCESS && bt_present) {
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next reply other threads:[~2008-11-08 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 13:37 Andrey Borzenkov [this message]
2008-11-11 20:04 ` [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality Len Brown
2008-11-12 23:41 ` Thomas Renninger
2008-11-13 1:32 ` Matthew Garrett
2008-11-13 4:58 ` Andrey Borzenkov
2008-11-13 11:11 ` Matthew Garrett
2008-11-15 16:30 ` Andrey Borzenkov
2008-11-15 16:54 ` Matthew Garrett
2008-11-15 17:05 ` Andrey Borzenkov
2008-11-15 17:11 ` Matthew Garrett
2008-11-15 17:17 ` Andrey Borzenkov
2008-11-15 17:20 ` Matthew Garrett
2008-11-15 18:42 ` Andrey Borzenkov
2008-11-15 18:49 ` Matthew Garrett
2008-11-16 12:51 ` Henrique de Moraes Holschuh
2008-11-16 21:44 ` Thomas Renninger
2008-11-17 2:07 ` Henrique de Moraes Holschuh
2008-11-27 5:19 ` Len Brown
2008-11-27 11:39 ` Video.ko-vs-toshiba.ko-more-brightness-levels-win Thomas Renninger
2008-11-27 11:39 ` [PATCH 1/2] ACPI: acpi_video_backlight_support return found generic video brightness levels Thomas Renninger
2008-11-27 12:08 ` Thomas Renninger
2008-11-27 11:39 ` [PATCH 2/2] Video.ko vs toshiba.ko - more brightness levels win Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811081637.45099.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox