* [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. [not found] <20081111080614.11705.79007.stgit@thinkpad> @ 2008-11-11 8:09 ` Alexey Starikovskiy 2008-11-11 8:59 ` Zhao Yakui 2008-11-11 9:25 ` Zhao Yakui 0 siblings, 2 replies; 6+ messages in thread From: Alexey Starikovskiy @ 2008-11-11 8:09 UTC (permalink / raw) To: LenBrown; +Cc: Linux-acpi Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> --- drivers/acpi/ec.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 628b076..b1dcc08 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -576,11 +576,15 @@ static u32 acpi_ec_gpe_handler(void *data) pr_debug(PREFIX "~~~> interrupt\n"); status = acpi_ec_read_status(ec); - gpe_transaction(ec, status); - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) - wake_up(&ec->wait); + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { + gpe_transaction(ec, status); + if (ec_transaction_done(ec) && + (status & ACPI_EC_FLAG_IBF) == 0) + wake_up(&ec->wait); + } ec_check_sci(ec, status); +#if 0 if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && !test_bit(EC_FLAGS_NO_GPE, &ec->flags)) { /* this is non-query, must be confirmation */ @@ -589,6 +593,7 @@ static u32 acpi_ec_gpe_handler(void *data) " switching to interrupt mode\n"); set_bit(EC_FLAGS_GPE_MODE, &ec->flags); } +#endif return ACPI_INTERRUPT_HANDLED; } ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. 2008-11-11 8:09 ` [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode Alexey Starikovskiy @ 2008-11-11 8:59 ` Zhao Yakui 2008-11-11 9:25 ` Zhao Yakui 1 sibling, 0 replies; 6+ messages in thread From: Zhao Yakui @ 2008-11-11 8:59 UTC (permalink / raw) To: Alexey Starikovskiy; +Cc: LenBrown, Linux-acpi@vger.kernel.org On Tue, 2008-11-11 at 16:09 +0800, Alexey Starikovskiy wrote: > Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> > --- > > drivers/acpi/ec.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 628b076..b1dcc08 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -576,11 +576,15 @@ static u32 acpi_ec_gpe_handler(void *data) > pr_debug(PREFIX "~~~> interrupt\n"); > status = acpi_ec_read_status(ec); > > - gpe_transaction(ec, status); > - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) > - wake_up(&ec->wait); > + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { > + gpe_transaction(ec, status); > + if (ec_transaction_done(ec) && > + (status & ACPI_EC_FLAG_IBF) == 0) > + wake_up(&ec->wait); > + } > It seems that the EC won't be switched to EC GPE mode in the EC GPE handler again after the following is added. >#if 0 >#endif Is it appropriate? If what I said is incorrect, please ignore it. Thanks. > ec_check_sci(ec, status); > +#if 0 > if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && > !test_bit(EC_FLAGS_NO_GPE, &ec->flags)) { > /* this is non-query, must be confirmation */ > @@ -589,6 +593,7 @@ static u32 acpi_ec_gpe_handler(void *data) > " switching to interrupt mode\n"); > set_bit(EC_FLAGS_GPE_MODE, &ec->flags); > } > +#endif > return ACPI_INTERRUPT_HANDLED; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. 2008-11-11 8:09 ` [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode Alexey Starikovskiy 2008-11-11 8:59 ` Zhao Yakui @ 2008-11-11 9:25 ` Zhao Yakui 2008-11-11 9:50 ` Alexey Starikovskiy 1 sibling, 1 reply; 6+ messages in thread From: Zhao Yakui @ 2008-11-11 9:25 UTC (permalink / raw) To: Alexey Starikovskiy; +Cc: LenBrown, Linux-acpi@vger.kernel.org On Tue, 2008-11-11 at 16:09 +0800, Alexey Starikovskiy wrote: > Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> > --- > > drivers/acpi/ec.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 628b076..b1dcc08 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -576,11 +576,15 @@ static u32 acpi_ec_gpe_handler(void *data) > pr_debug(PREFIX "~~~> interrupt\n"); > status = acpi_ec_read_status(ec); > > - gpe_transaction(ec, status); > - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) > - wake_up(&ec->wait); > + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { > + gpe_transaction(ec, status); > + if (ec_transaction_done(ec) && > + (status & ACPI_EC_FLAG_IBF) == 0) > + wake_up(&ec->wait); > + } > > ec_check_sci(ec, status); Sorry that I don't describe it very clearly in the previous email. It seems that the EC won't be switched from polling mode to EC GPE mode after the following is added. >#if 0 >#endif In such case the EC will always work in polling mode. And EC GPE storm also can't be detected. I am not sure what I have said is correct. If not correct, please ignore it. If correct, is it appropriate that the default work mode is set as EC GPE mode? Thanks. Yakui > +#if 0 > if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && > !test_bit(EC_FLAGS_NO_GPE, &ec->flags)) { > /* this is non-query, must be confirmation */ > @@ -589,6 +593,7 @@ static u32 acpi_ec_gpe_handler(void *data) > " switching to interrupt mode\n"); > set_bit(EC_FLAGS_GPE_MODE, &ec->flags); > } > +#endif > return ACPI_INTERRUPT_HANDLED; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. 2008-11-11 9:25 ` Zhao Yakui @ 2008-11-11 9:50 ` Alexey Starikovskiy 2008-11-11 9:54 ` Alexey Starikovskiy 0 siblings, 1 reply; 6+ messages in thread From: Alexey Starikovskiy @ 2008-11-11 9:50 UTC (permalink / raw) To: Zhao Yakui; +Cc: LenBrown, Linux-acpi@vger.kernel.org Yakui, Thanks, I've sent my development patch -- I disabled switch to interrupt mode in order to test poll mode behaviour in presence of interrupts. Proper patch will not include "#if 0", only if () around gpe_transaction(). Regards, Alex. Zhao Yakui wrote: > On Tue, 2008-11-11 at 16:09 +0800, Alexey Starikovskiy wrote: >> Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 >> >> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> >> --- >> >> drivers/acpi/ec.c | 11 ++++++++--- >> 1 files changed, 8 insertions(+), 3 deletions(-) >> >> >> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c >> index 628b076..b1dcc08 100644 >> --- a/drivers/acpi/ec.c >> +++ b/drivers/acpi/ec.c >> @@ -576,11 +576,15 @@ static u32 acpi_ec_gpe_handler(void *data) >> pr_debug(PREFIX "~~~> interrupt\n"); >> status = acpi_ec_read_status(ec); >> >> - gpe_transaction(ec, status); >> - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) >> - wake_up(&ec->wait); >> + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { >> + gpe_transaction(ec, status); >> + if (ec_transaction_done(ec) && >> + (status & ACPI_EC_FLAG_IBF) == 0) >> + wake_up(&ec->wait); >> + } >> >> ec_check_sci(ec, status); > Sorry that I don't describe it very clearly in the previous email. > It seems that the EC won't be switched from polling mode to EC GPE mode > after the following is added. > >#if 0 > >#endif > In such case the EC will always work in polling mode. And EC GPE > storm also can't be detected. > > I am not sure what I have said is correct. If not correct, please ignore > it. > If correct, is it appropriate that the default work mode is set as EC > GPE mode? > Thanks. > Yakui > >> +#if 0 >> if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && >> !test_bit(EC_FLAGS_NO_GPE, &ec->flags)) { >> /* this is non-query, must be confirmation */ >> @@ -589,6 +593,7 @@ static u32 acpi_ec_gpe_handler(void *data) >> " switching to interrupt mode\n"); >> set_bit(EC_FLAGS_GPE_MODE, &ec->flags); >> } >> +#endif >> return ACPI_INTERRUPT_HANDLED; >> } >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. 2008-11-11 9:50 ` Alexey Starikovskiy @ 2008-11-11 9:54 ` Alexey Starikovskiy 2008-11-11 22:22 ` Len Brown 0 siblings, 1 reply; 6+ messages in thread From: Alexey Starikovskiy @ 2008-11-11 9:54 UTC (permalink / raw) To: LenBrown; +Cc: Linux-acpi Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> --- drivers/acpi/ec.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 628b076..985fb50 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -576,9 +576,12 @@ static u32 acpi_ec_gpe_handler(void *data) pr_debug(PREFIX "~~~> interrupt\n"); status = acpi_ec_read_status(ec); - gpe_transaction(ec, status); - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) - wake_up(&ec->wait); + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { + gpe_transaction(ec, status); + if (ec_transaction_done(ec) && + (status & ACPI_EC_FLAG_IBF) == 0) + wake_up(&ec->wait); + } ec_check_sci(ec, status); if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode. 2008-11-11 9:54 ` Alexey Starikovskiy @ 2008-11-11 22:22 ` Len Brown 0 siblings, 0 replies; 6+ messages in thread From: Len Brown @ 2008-11-11 22:22 UTC (permalink / raw) To: Alexey Starikovskiy; +Cc: Linux-acpi applied. thanks, -len On Tue, 11 Nov 2008, Alexey Starikovskiy wrote: > Referencies: http://bugzilla.kernel.org/show_bug.cgi?id=12004 > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> > --- > > drivers/acpi/ec.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index 628b076..985fb50 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -576,9 +576,12 @@ static u32 acpi_ec_gpe_handler(void *data) > pr_debug(PREFIX "~~~> interrupt\n"); > status = acpi_ec_read_status(ec); > > - gpe_transaction(ec, status); > - if (ec_transaction_done(ec) && (status & ACPI_EC_FLAG_IBF) == 0) > - wake_up(&ec->wait); > + if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags)) { > + gpe_transaction(ec, status); > + if (ec_transaction_done(ec) && > + (status & ACPI_EC_FLAG_IBF) == 0) > + wake_up(&ec->wait); > + } > > ec_check_sci(ec, status); > if (!test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-11-11 22:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20081111080614.11705.79007.stgit@thinkpad>
2008-11-11 8:09 ` [PATCH] ACPI: EC: Don't do transaction from GPE handler in poll mode Alexey Starikovskiy
2008-11-11 8:59 ` Zhao Yakui
2008-11-11 9:25 ` Zhao Yakui
2008-11-11 9:50 ` Alexey Starikovskiy
2008-11-11 9:54 ` Alexey Starikovskiy
2008-11-11 22:22 ` Len Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox