* [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
@ 2008-11-03 9:16 Andrey Borzenkov
2008-11-11 22:24 ` Andrew Morton
2008-11-12 6:37 ` Len Brown
0 siblings, 2 replies; 5+ messages in thread
From: Andrey Borzenkov @ 2008-11-03 9:16 UTC (permalink / raw)
To: linux-acpi; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
From: Andrey Borzenkov <arvidjaar@mail.ru>
CC drivers/acpi/glue.o
/home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
/home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
---
drivers/acpi/glue.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
index 98c9c76..436c8a3 100644
--- a/drivers/acpi/glue.c
+++ b/drivers/acpi/glue.c
@@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
struct device *acpi_get_physical_pci_device(acpi_handle handle)
{
struct device *dev;
- long device_id;
+ unsigned long long device_id;
acpi_status status;
status =
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
2008-11-03 9:16 [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device Andrey Borzenkov
@ 2008-11-11 22:24 ` Andrew Morton
2008-11-12 3:42 ` Andrey Borzenkov
2008-11-12 6:37 ` Len Brown
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2008-11-11 22:24 UTC (permalink / raw)
To: Andrey Borzenkov; +Cc: linux-acpi, linux-kernel
On Mon, 3 Nov 2008 12:16:13 +0300
Andrey Borzenkov <arvidjaar@mail.ru> wrote:
> Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> From: Andrey Borzenkov <arvidjaar@mail.ru>
>
> CC drivers/acpi/glue.o
> /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
>
> acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
>
> Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
>
> ---
>
> drivers/acpi/glue.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> index 98c9c76..436c8a3 100644
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> struct device *acpi_get_physical_pci_device(acpi_handle handle)
> {
> struct device *dev;
> - long device_id;
> + unsigned long long device_id;
> acpi_status status;
>
> status =
Someone has gone and changed this to `long long', which is still wrong
but which (surprisingly) doesn't seem to generate a compilation
warning.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
2008-11-11 22:24 ` Andrew Morton
@ 2008-11-12 3:42 ` Andrey Borzenkov
0 siblings, 0 replies; 5+ messages in thread
From: Andrey Borzenkov @ 2008-11-12 3:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-acpi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]
On Wednesday 12 November 2008, Andrew Morton wrote:
> On Mon, 3 Nov 2008 12:16:13 +0300
> Andrey Borzenkov <arvidjaar@mail.ru> wrote:
>
> > Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> > From: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > CC drivers/acpi/glue.o
> > /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> > /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
> >
> > acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
> >
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > ---
> >
> > drivers/acpi/glue.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >
> > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> > index 98c9c76..436c8a3 100644
> > --- a/drivers/acpi/glue.c
> > +++ b/drivers/acpi/glue.c
> > @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> > struct device *acpi_get_physical_pci_device(acpi_handle handle)
> > {
> > struct device *dev;
> > - long device_id;
> > + unsigned long long device_id;
> > acpi_status status;
> >
> > status =
>
> Someone has gone and changed this to `long long', which is still wrong
> but which (surprisingly) doesn't seem to generate a compilation
> warning.
>
>
Well, size became correct and this is probably what matters most here. I still
do not quite understand what made this function so special comparing to all
others.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
2008-11-03 9:16 [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device Andrey Borzenkov
2008-11-11 22:24 ` Andrew Morton
@ 2008-11-12 6:37 ` Len Brown
2008-11-12 17:34 ` Andrey Borzenkov
1 sibling, 1 reply; 5+ messages in thread
From: Len Brown @ 2008-11-12 6:37 UTC (permalink / raw)
To: Andrey Borzenkov; +Cc: linux-acpi, Linux Kernel Mailing List
unclear what kernel this is supposed to apply to.
On Mon, 3 Nov 2008, Andrey Borzenkov wrote:
> Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> From: Andrey Borzenkov <arvidjaar@mail.ru>
>
> CC drivers/acpi/glue.o
> /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
>
> acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
>
> Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
>
> ---
>
> drivers/acpi/glue.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> index 98c9c76..436c8a3 100644
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> struct device *acpi_get_physical_pci_device(acpi_handle handle)
> {
> struct device *dev;
> - long device_id;
> + unsigned long long device_id;
> acpi_status status;
>
> status =
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
2008-11-12 6:37 ` Len Brown
@ 2008-11-12 17:34 ` Andrey Borzenkov
0 siblings, 0 replies; 5+ messages in thread
From: Andrey Borzenkov @ 2008-11-12 17:34 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
On Wednesday 12 November 2008, Len Brown wrote:
> unclear what kernel this is supposed to apply to.
>
The patch was against 2.6.28-rc3 and applies to rc4 as well. Sorry
for not mentioning this (I thought I did)
> On Mon, 3 Nov 2008, Andrey Borzenkov wrote:
>
> > Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> > From: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > CC drivers/acpi/glue.o
> > /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> > /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
> >
> > acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
> >
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > ---
> >
> > drivers/acpi/glue.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >
> > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> > index 98c9c76..436c8a3 100644
> > --- a/drivers/acpi/glue.c
> > +++ b/drivers/acpi/glue.c
> > @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> > struct device *acpi_get_physical_pci_device(acpi_handle handle)
> > {
> > struct device *dev;
> > - long device_id;
> > + unsigned long long device_id;
> > acpi_status status;
> >
> > status =
> >
>
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-11-12 17:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-03 9:16 [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device Andrey Borzenkov
2008-11-11 22:24 ` Andrew Morton
2008-11-12 3:42 ` Andrey Borzenkov
2008-11-12 6:37 ` Len Brown
2008-11-12 17:34 ` Andrey Borzenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox