From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Avi Kivity <avi@redhat.com>,
Andrey Borzenkov <arvidjaar@mail.ru>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eduardo Habkost <ehabkost@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again)
Date: Tue, 11 Nov 2008 21:44:44 +0100 [thread overview]
Message-ID: <20081111204444.GB8853@elte.hu> (raw)
In-Reply-To: <m1abc6qa5b.fsf@frodo.ebiederm.org>
* Eric W. Biederman <ebiederm@xmission.com> wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
> > Ingo Molnar wrote:
> >>
> >> well then we could insert CF9 to before the triple fault, and solve
> >> some of the problems as well, without unnecessary risks.
> >>
> >> This is a separate patch from ACPI reboot itself, naturally.
> >>
> >
> > This is a pretty good point. There is extremely low risk of being
> > something at port CF9 that is something other than the reset
> > register. It may not be there, but if it isn't, the worst thing
> > that happened is we confused a device right before reset.
> >
> > Even better if we condition the port CF9 write on existence a PCI
> > bus (or even more specifically PCI Configuration Method #1 or #2).
> > Port CF9 is extremely unlikely to exist on a machine without a PCI
> > bus, and extremely unlikely to conflict with anything else on a
> > machine with a PCI bus.
>
> Yes. What we are guarding against in practice is a write that
> causes the system to hang. Anything else and we will make it to the
> next reset method.
yeah. Patches are welcome :)
Ingo
next prev parent reply other threads:[~2008-11-11 20:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 4:45 ACPI patchese on test branch Len Brown
2008-11-07 4:45 ` [PATCH 01/10] ACPI: pci_link: remove acpi_irq_balance_set() interface Len Brown
2008-11-07 4:45 ` [PATCH 02/10] ACPI: Disambiguate processor declaration type Len Brown
2008-11-07 4:45 ` [PATCH 03/10] ACPI: Behave uniquely based on processor declaration definition type Len Brown
2008-11-07 4:45 ` [PATCH 04/10] ACPI: 80 column adherence and spelling fix (no functional change) Len Brown
2008-11-07 4:45 ` [PATCH 05/10] Hibernate: Call platform_begin before swsusp_shrink_memory Len Brown
2008-11-07 4:45 ` [PATCH 06/10] ACPI hibernate: Add a mechanism to save/restore ACPI NVS memory Len Brown
2008-11-07 4:45 ` [PATCH 07/10] x86 hibernate: Mark ACPI NVS memory region at startup Len Brown
2008-11-07 4:45 ` [PATCH 08/10] ACPI hibernate: Introduce new kernel parameter acpi_sleep=s4_nonvs Len Brown
2008-11-07 4:45 ` [PATCH 09/10] compal-laptop: use rfkill switch subsystem Len Brown
2008-11-07 4:45 ` [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again) Len Brown
2008-11-07 7:25 ` Ingo Molnar
2008-11-08 1:41 ` Len Brown
2008-11-08 6:30 ` Andrey Borzenkov
2008-11-08 7:12 ` Len Brown
2008-11-08 7:50 ` Andrey Borzenkov
2008-11-08 11:59 ` Ingo Molnar
2008-11-09 9:55 ` Avi Kivity
2008-11-09 10:00 ` H. Peter Anvin
2008-11-10 8:39 ` Ingo Molnar
2008-11-10 8:54 ` Avi Kivity
2008-11-10 9:02 ` Ingo Molnar
2008-11-11 18:26 ` H. Peter Anvin
2008-11-11 20:29 ` Eric W. Biederman
2008-11-11 20:44 ` Ingo Molnar [this message]
2008-11-10 11:59 ` Matthew Garrett
2008-11-10 11:57 ` Matthew Garrett
2008-11-10 12:56 ` Ingo Molnar
2008-11-10 13:00 ` Matthew Garrett
2008-11-11 23:14 ` Len Brown
2008-11-12 0:25 ` Attempt rebooting via port CF9 if it seems to be available H. Peter Anvin
2008-11-12 18:49 ` Andrey Borzenkov
2008-11-12 0:27 ` [PATCH 10/10] x86, ACPI: default to reboot via ACPI (again) Matthew Garrett
2008-11-12 11:58 ` Ingo Molnar
2008-11-12 12:23 ` Avi Kivity
2008-11-13 3:23 ` Zhao Yakui
2008-11-13 3:18 ` H. Peter Anvin
2008-11-13 3:43 ` Zhao Yakui
2008-11-13 4:10 ` Eric W. Biederman
2008-11-13 4:34 ` H. Peter Anvin
2008-11-13 4:14 ` Eric W. Biederman
2008-11-13 5:29 ` Zhao Yakui
2008-11-13 5:25 ` H. Peter Anvin
2008-11-13 6:56 ` Eric W. Biederman
2008-11-13 6:58 ` Eric W. Biederman
2008-11-13 9:06 ` Zhao Yakui
2008-11-13 17:42 ` H. Peter Anvin
2008-11-14 1:29 ` Zhao Yakui
2008-11-14 1:22 ` H. Peter Anvin
2008-11-14 1:49 ` Zhao Yakui
2008-11-13 3:29 ` Stephen Rothwell
2008-11-08 12:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111204444.GB8853@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arvidjaar@mail.ru \
--cc=avi@redhat.com \
--cc=ebiederm@xmission.com \
--cc=ehabkost@redhat.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox