Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device

[Andrey Borzenkov <arvidjaar@mail.ru>]

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

On Wednesday 12 November 2008, Andrew Morton wrote:
> On Mon, 3 Nov 2008 12:16:13 +0300
> Andrey Borzenkov <arvidjaar@mail.ru> wrote:
> 
> > Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> > From: Andrey Borzenkov <arvidjaar@mail.ru>
> > 
> > CC      drivers/acpi/glue.o
> > /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> > /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
> > 
> > acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
> > 
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> > 
> > ---
> > 
> >  drivers/acpi/glue.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > 
> > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> > index 98c9c76..436c8a3 100644
> > --- a/drivers/acpi/glue.c
> > +++ b/drivers/acpi/glue.c
> > @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> >  struct device *acpi_get_physical_pci_device(acpi_handle handle)
> >  {
> >  	struct device *dev;
> > -	long device_id;
> > +	unsigned long long device_id;
> >  	acpi_status status;
> >  
> >  	status =
> 
> Someone has gone and changed this to `long long', which is still wrong
> but which (surprisingly) doesn't seem to generate a compilation
> warning.
> 
> 

Well, size became correct and this is probably what matters most here. I still
do not quite understand what made this function so special comparing to all
others.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]