From: Thomas Renninger <trenn@suse.de>
To: Alessandro Guido <ag@alessandroguido.name>
Cc: len.brown@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [sony-laptop] Fix regression caused by "sony-laptop: fingers off backlight if video.ko is serving this functionality"
Date: Wed, 12 Nov 2008 16:27:12 -0600 [thread overview]
Message-ID: <200811121627.13525.trenn@suse.de> (raw)
In-Reply-To: <200811122303.29372.ag@alessandroguido.name>
On Wednesday 12 November 2008 04:03:28 pm Alessandro Guido wrote:
> After commit 540b8bb9c33935183ceb5bed466a42ad72b2af56:
>
> sony-laptop: fingers off backlight if video.ko is serving this
> functionality
>
> I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
> dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by
> ACPI video driver".
> The function acpi_video_backlight_support returns 0 if we should use the
> vendor-specific backlight support, while non-0 if the ACPI generic should
> be used. Because of this, the check introduced by the said commit appears
> reversed.
>
> Signed-off-by: Alessandro Guido <ag@alessandroguido.name>
Thanks for finding this stupid typo,
Thomas
> ---
> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
> index 7bcb810..2a613d4 100644
> --- a/drivers/misc/sony-laptop.c
> +++ b/drivers/misc/sony-laptop.c
> @@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
> goto outinput;
> }
>
> - if (!acpi_video_backlight_support()) {
> + if (acpi_video_backlight_support()) {
> printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
> "controlled by ACPI video driver\n");
> } else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",
next prev parent reply other threads:[~2008-11-12 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 22:03 [sony-laptop] Fix regression caused by "sony-laptop: fingers off backlight if video.ko is serving this functionality" Alessandro Guido
2008-11-12 22:27 ` Thomas Renninger [this message]
2008-11-13 5:56 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811121627.13525.trenn@suse.de \
--to=trenn@suse.de \
--cc=ag@alessandroguido.name \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox