From: Andrey Borzenkov <arvidjaar@mail.ru>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
Date: Wed, 12 Nov 2008 20:34:07 +0300 [thread overview]
Message-ID: <200811122034.08092.arvidjaar@mail.ru> (raw)
In-Reply-To: <alpine.LFD.2.00.0811120137070.3828@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
On Wednesday 12 November 2008, Len Brown wrote:
> unclear what kernel this is supposed to apply to.
>
The patch was against 2.6.28-rc3 and applies to rc4 as well. Sorry
for not mentioning this (I thought I did)
> On Mon, 3 Nov 2008, Andrey Borzenkov wrote:
>
> > Subject: [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device
> > From: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > CC drivers/acpi/glue.o
> > /home/bor/src/linux-git/drivers/acpi/glue.c: In function 'acpi_get_physical_pci_device':
> > /home/bor/src/linux-git/drivers/acpi/glue.c:157: warning: passing argument 4 of 'acpi_evaluate_integer' from incompatible pointer type
> >
> > acpi_evaluate_integer takes pointer to unsigned long long as fourth argument
> >
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> >
> > ---
> >
> > drivers/acpi/glue.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >
> > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
> > index 98c9c76..436c8a3 100644
> > --- a/drivers/acpi/glue.c
> > +++ b/drivers/acpi/glue.c
> > @@ -150,7 +150,7 @@ EXPORT_SYMBOL(acpi_get_physical_device);
> > struct device *acpi_get_physical_pci_device(acpi_handle handle)
> > {
> > struct device *dev;
> > - long device_id;
> > + unsigned long long device_id;
> > acpi_status status;
> >
> > status =
> >
>
>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-11-12 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 9:16 [PATCH] Fix argument type for acpi_evaluate_integer in acpi_get_physical_pci_device Andrey Borzenkov
2008-11-11 22:24 ` Andrew Morton
2008-11-12 3:42 ` Andrey Borzenkov
2008-11-12 6:37 ` Len Brown
2008-11-12 17:34 ` Andrey Borzenkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811122034.08092.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox