From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: Len Brown <lenb@kernel.org>, Andrey Borzenkov <arvidjaar@mail.ru>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality
Date: Thu, 13 Nov 2008 01:32:59 +0000 [thread overview]
Message-ID: <20081113013259.GA24790@srcf.ucam.org> (raw)
In-Reply-To: <200811121741.36296.trenn@suse.de>
On Wed, Nov 12, 2008 at 05:41:35PM -0600, Thomas Renninger wrote:
> On Tuesday 11 November 2008 02:04:15 pm Len Brown wrote:
> > so when i apply this patch, i get fewer brightness levels.
> > I prefer to have all 8 brightness levels.
>
> The patch from Andrey is correct.
> Looks like all, the ordinary user needs, and probably the way it works on a
> plain Vista OS is there: off, battery, full level.
> You can still use the boot param for your specific needs:
> acpi_display_output=vendor
The Toshiba BIOSes I've looked at all implement the ACPI code on top of
the legacy interface. Do you have examples where that's not the case? If
not, I don't see the harm in exposing both.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-11-13 1:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 13:37 [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality Andrey Borzenkov
2008-11-11 20:04 ` Len Brown
2008-11-12 23:41 ` Thomas Renninger
2008-11-13 1:32 ` Matthew Garrett [this message]
2008-11-13 4:58 ` Andrey Borzenkov
2008-11-13 11:11 ` Matthew Garrett
2008-11-15 16:30 ` Andrey Borzenkov
2008-11-15 16:54 ` Matthew Garrett
2008-11-15 17:05 ` Andrey Borzenkov
2008-11-15 17:11 ` Matthew Garrett
2008-11-15 17:17 ` Andrey Borzenkov
2008-11-15 17:20 ` Matthew Garrett
2008-11-15 18:42 ` Andrey Borzenkov
2008-11-15 18:49 ` Matthew Garrett
2008-11-16 12:51 ` Henrique de Moraes Holschuh
2008-11-16 21:44 ` Thomas Renninger
2008-11-17 2:07 ` Henrique de Moraes Holschuh
2008-11-27 5:19 ` Len Brown
2008-11-27 11:39 ` Video.ko-vs-toshiba.ko-more-brightness-levels-win Thomas Renninger
2008-11-27 11:39 ` [PATCH 1/2] ACPI: acpi_video_backlight_support return found generic video brightness levels Thomas Renninger
2008-11-27 12:08 ` Thomas Renninger
2008-11-27 11:39 ` [PATCH 2/2] Video.ko vs toshiba.ko - more brightness levels win Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113013259.GA24790@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=arvidjaar@mail.ru \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox