Re: The regression about EC GPE storm on the latest linus git tree

Re: The regression about EC GPE storm on the latest linus git tree

[Alexey Starikovskiy]

Hi Yakui,

Does your latest kernel include yesterday pool of patches? 

Thanks,
Alex.
Zhao Yakui wrote:
> Hi, Alexey
>     I do some tests on the latest kernel and find that there exists the
> EC GPE storm on the three laptops. And then EC will work in polling
> mode. One is Asus EEEPC 1000. The other are HP laptops. 
>     
>     I do the similar test on the previous kernel(for example:
> 2.6.27-rc6, 2.6.27.4) and there is no EC GPE storm on the three laptops.
> The EC works in EC GPE interrupt mode. 
>     After the EC debug is used on the 2.6.27-rc6 kernel, I find that at
> most 8 EC interrupts are triggered in each EC transaction(This includes
> the effective EC GPE interrupts). In such case it should not be regarded
> as EC GPE storm.
>        
>     The attached are the dmesg info on the Asus EEEPC 1000. (One is
> based on the latest git tree. One is based on 2.6.27-rc6 kernel).
>     If you need to investigate the root cause about the EC GPE storm,
> please tell me what I should do. I will try my best to test the patch
> from you and give response.
> 
> Thanks.
>    Yakui
>  
> 

[PATCH] ACPI: EC: count interrupts only if called from interrupt handler.

[Alexey Starikovskiy]

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index cf41f9f..30f3ef2 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -219,7 +219,8 @@ static void gpe_transaction(struct acpi_ec *ec, u8 status)
 	goto unlock;
 err:
 	/* false interrupt, state didn't change */
-	++ec->curr->irq_count;
+	if (in_interrupt())
+		++ec->curr->irq_count;
 unlock:
 	spin_unlock_irqrestore(&ec->curr_lock, flags);
 }

Re: [PATCH] ACPI: EC: count interrupts only if called from interrupt handler.

[Zhao Yakui]

On Thu, 2008-11-13 at 17:00 +0800, Alexey Starikovskiy wrote:
> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Thanks for the patch.
   After applying the patch, there is no EC GPE storm and EC will work
in EC GPE interrupt mode. It works as what we expected.
Thanks for the patch again.

> ---
> 
>  drivers/acpi/ec.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index cf41f9f..30f3ef2 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -219,7 +219,8 @@ static void gpe_transaction(struct acpi_ec *ec, u8 status)
>  	goto unlock;
>  err:
>  	/* false interrupt, state didn't change */
> -	++ec->curr->irq_count;
> +	if (in_interrupt())
> +		++ec->curr->irq_count;
>  unlock:
>  	spin_unlock_irqrestore(&ec->curr_lock, flags);
>  }
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ACPI: EC: count interrupts only if called from interrupt handler.

[Len Brown]

applied for 2.6.28

thanks,
-len

On Thu, 13 Nov 2008, Alexey Starikovskiy wrote:

> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> ---
> 
>  drivers/acpi/ec.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index cf41f9f..30f3ef2 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -219,7 +219,8 @@ static void gpe_transaction(struct acpi_ec *ec, u8 status)
>  	goto unlock;
>  err:
>  	/* false interrupt, state didn't change */
> -	++ec->curr->irq_count;
> +	if (in_interrupt())
> +		++ec->curr->irq_count;
>  unlock:
>  	spin_unlock_irqrestore(&ec->curr_lock, flags);
>  }
>