From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: Thomas Renninger <trenn@suse.de>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality
Date: Sat, 15 Nov 2008 17:20:52 +0000 [thread overview]
Message-ID: <20081115172052.GA9537@srcf.ucam.org> (raw)
In-Reply-To: <200811152017.56926.arvidjaar@mail.ru>
On Sat, Nov 15, 2008 at 08:17:52PM +0300, Andrey Borzenkov wrote:
> On Saturday 15 November 2008, Matthew Garrett wrote:
> > > If you think exposing both knobs is non-issue, why are all those patches
> > > for other vendor drivers included in the kernel in the first place?
> >
> > Because in some of those cases, the ACPI and vendor function are
> > implemented in different ways that can then get out of sync with each
> > other. As a result, you can get garbage information. If the values in
> > your two backlight interfaces are always sane, then there's no inherent
> > need to hide one of them.
>
> THE VALUE IN MY TWO BACKLIGHT INTERFACES ARE NOT THE SAME. I said this many
> times already. What exactly is not clear in this sentence?
Where did I say that they were? You never answered the question I asked
- if you set the value in the toshiba specific backlight control to a
value that isn't supported via the generic acpi one, what value does the
generic acpi one claim to have?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-11-15 17:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 13:37 [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality Andrey Borzenkov
2008-11-11 20:04 ` Len Brown
2008-11-12 23:41 ` Thomas Renninger
2008-11-13 1:32 ` Matthew Garrett
2008-11-13 4:58 ` Andrey Borzenkov
2008-11-13 11:11 ` Matthew Garrett
2008-11-15 16:30 ` Andrey Borzenkov
2008-11-15 16:54 ` Matthew Garrett
2008-11-15 17:05 ` Andrey Borzenkov
2008-11-15 17:11 ` Matthew Garrett
2008-11-15 17:17 ` Andrey Borzenkov
2008-11-15 17:20 ` Matthew Garrett [this message]
2008-11-15 18:42 ` Andrey Borzenkov
2008-11-15 18:49 ` Matthew Garrett
2008-11-16 12:51 ` Henrique de Moraes Holschuh
2008-11-16 21:44 ` Thomas Renninger
2008-11-17 2:07 ` Henrique de Moraes Holschuh
2008-11-27 5:19 ` Len Brown
2008-11-27 11:39 ` Video.ko-vs-toshiba.ko-more-brightness-levels-win Thomas Renninger
2008-11-27 11:39 ` [PATCH 1/2] ACPI: acpi_video_backlight_support return found generic video brightness levels Thomas Renninger
2008-11-27 12:08 ` Thomas Renninger
2008-11-27 11:39 ` [PATCH 2/2] Video.ko vs toshiba.ko - more brightness levels win Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081115172052.GA9537@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=arvidjaar@mail.ru \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox