Re: [PATCH] toshiba_acpi: fingers off backlight if video.ko is serving this functionality

Andrey Borzenkov
2008-11-15T17:05:10Z

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On Saturday 15 November 2008, Matthew Garrett wrote:
> On Sat, Nov 15, 2008 at 07:30:57PM +0300, Andrey Borzenkov wrote:
> > On Thursday 13 November 2008, Matthew Garrett wrote:
> > > On Thu, Nov 13, 2008 at 07:58:09AM +0300, Andrey Borzenkov wrote:
> > >
> > > > - exposing two knobs for the *same* thing confuses user level tools; you never
> > > > know which one is used and they compete behind your back
> > >
> > > How do they compete?
> >
> > In my case user level program (kpowersave) decided to use video.ko for
> > brightness control (or, may be, it used them both). Which gave me 2 levels
> > instead of 8. And there is no way to control it, at least known to me.
>
> Right. But that doesn't mean they're competing, as such. If you set the
> brightness via toshiba_acpi

I probably have problems with expressing myself as non-native English
speaker.

I am not interested in setting values via echoing into sysfs file. I
am interested in my desktop brightness control working out of the box.
And desktop driver control has no way to select, which of two sysfs
files to use. Nor do I understand why I have to create this problem
of selecting right driver when I already have possibility to avoid it.

If you think exposing both knobs is non-issue, why are all those patches
for other vendor drivers included in the kernel in the first place?

> to a value that isn't supported via the
> acpi driver, what value does the acpi backlight claim to be at?
>

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]