public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
	"Zhao, Yakui" <yakui.zhao@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	LKML <linux-kernel@vger.kernel.org>, walken <walken@zoy.org>
Subject: [PATCH] ACPI: Revert commit faee816b150238 due to regression
Date: Tue, 25 Nov 2008 10:36:52 +0100	[thread overview]
Message-ID: <200811251036.53084.rjw@sisk.pl> (raw)
In-Reply-To: <1227576051.15014.305.camel@rzhang-dt>

From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: ACPI: Revert commit faee816b150238 due to regression

Commit faee816b1502385dc9bc5abf2960d1cc645844d1
"ACPI: don't enable control method power button as wakeup device
when Fixed Power button is used" caused the regression tracked
as http://bugzilla.kernel.org/show_bug.cgi?id=12091 (there are no
AC adapter events on Toshiba Portege R500) and the problem this
commit was intended to fix can be fixed differently.

For this reason, the author of the commit, Zhang Rui, has requested
that it be reverted.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/scan.c |   10 ----------
 1 file changed, 10 deletions(-)

Index: linux-2.6/drivers/acpi/scan.c
===================================================================
--- linux-2.6.orig/drivers/acpi/scan.c
+++ linux-2.6/drivers/acpi/scan.c
@@ -751,16 +751,6 @@ static int acpi_bus_get_wakeup_device_fl
 	if (!acpi_match_device_ids(device, button_device_ids))
 		device->wakeup.flags.run_wake = 1;
 
-	/*
-	 * Don't set Power button GPE as run_wake
-	 * if Fixed Power button is used
-	 */
-	if (!strcmp(device->pnp.hardware_id, "PNP0C0C") &&
-		!(acpi_gbl_FADT.flags & ACPI_FADT_POWER_BUTTON)) {
-		device->wakeup.flags.run_wake = 0;
-		device->wakeup.flags.valid = 0;
-	}
-
       end:
 	if (ACPI_FAILURE(status))
 		device->flags.wake_capable = 0;

  parent reply	other threads:[~2008-11-25  9:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-22 23:53 Regression: ACPI AC driver doesn't work on Toshiba Portege R500 Rafael J. Wysocki
2008-11-23 23:37 ` Regression: ACPI AC driver doesn't work on Toshiba Portege R500 (bisected) Rafael J. Wysocki
2008-11-24  1:02   ` Rafael J. Wysocki
2008-11-24 13:27     ` Rafael J. Wysocki
2008-11-24  1:15   ` Zhao Yakui
2008-11-24  1:21     ` Rafael J. Wysocki
2008-11-24  1:31       ` Zhang Rui
2008-11-24 13:30         ` Rafael J. Wysocki
2008-11-25  1:20           ` Zhang Rui
2008-11-25  9:06             ` Rafael J. Wysocki
2008-11-25  9:36             ` Rafael J. Wysocki [this message]
2008-11-25  1:24           ` Zhao Yakui
2008-11-25  9:08             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811251036.53084.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=astarikovskiy@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=walken@zoy.org \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox