* [PATCH -regression fix] ACPI: Fix ACPI battery regression introduced by commit 558073
@ 2008-12-05 0:07 Rafael J. Wysocki
0 siblings, 0 replies; only message in thread
From: Rafael J. Wysocki @ 2008-12-05 0:07 UTC (permalink / raw)
To: Len Brown
Cc: ACPI Devel Maling List, Alexey Starikovskiy, Andrew Morton,
Linus Torvalds, LKML
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: ACPI: Fix ACPI battery regression introduced by commit 558073
Commit 558073dd56707864f09d563b64e7c37c021e89d2
"ACPI: battery: Convert discharge energy rate to current properly"
caused the battery subsystem to report wrong values of the remaining
time on battery power and the time until fully charged on Toshiba
Portege R500 (and presumably on other boxes too).
Fix the issue by correcting the conversion from mW to mA.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/battery.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
Index: linux-2.6/drivers/acpi/battery.c
===================================================================
--- linux-2.6.orig/drivers/acpi/battery.c
+++ linux-2.6/drivers/acpi/battery.c
@@ -173,14 +173,17 @@ static int acpi_battery_get_property(str
val->intval = battery->voltage_now * 1000;
break;
case POWER_SUPPLY_PROP_CURRENT_NOW:
- val->intval = battery->current_now * 1000;
- /* if power units are mW, convert to mA by
- dividing by current voltage (mV/1000) */
- if (!battery->power_unit) {
- if (battery->voltage_now) {
+ val->intval = battery->current_now;
+ if (battery->power_unit) {
+ val->intval *= 1000;
+ } else {
+ /*
+ * If power units are mW, convert to mA by dividing by
+ * current voltage.
+ */
+ if (battery->voltage_now)
val->intval /= battery->voltage_now;
- val->intval *= 1000;
- } else
+ else
val->intval = -1;
}
break;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-05 0:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-05 0:07 [PATCH -regression fix] ACPI: Fix ACPI battery regression introduced by commit 558073 Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox