public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Witold Szczeponik <Witold.Szczeponik@gmx.net>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Helgaas <bjorn.helgaas@hp.com>, Adam Belay <abelay@mit.edu>,
	rjw@sisk.pl
Subject: Re: [PATCH] PNPACPI: Enable Power Support
Date: Wed, 10 Dec 2008 07:53:15 -0200	[thread overview]
Message-ID: <20081210095315.GA20627@khazad-dum.debian.net> (raw)
In-Reply-To: <493D8A1F.2090907@gmx.net>

On Mon, 08 Dec 2008, Witold Szczeponik wrote:
> This patch sets the power of PnP ACPI devices to D0 when they
> are activated and to D3 when they are disabled.  The latter is

This will likely fix my T43 to power down USB during STR. THANKS!!
Now, I just need to check if the ACPI BIOS is smart enough to not do
it when they are configured as wake devices [in the BIOS].

Although I do wonder WTF we don't do that on our USB UHCI/EHCI kernel
drivers, that ACPI needs to step in to fix it.  If it is not a wake
device, why are we leaving it powered up?  It is bad enough we don't
have any sort of proper USB power control, but to leave the entire USB
subsystem powered up without reason?!

Vista not only powers down the USB HCIs and ports on STR, it also
powers down ports when you "safely remove the USB device", and seems
to leave the port powered down until you insert a device (or remove
the device already in there, whatever).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  parent reply	other threads:[~2008-12-10  9:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-08 20:57 [PATCH] PNPACPI: Enable Power Support Witold Szczeponik
2008-12-09  2:49 ` Adam M Belay
2008-12-09  3:00   ` Bjorn Helgaas
2008-12-09  3:25     ` Adam M Belay
2008-12-10 19:32   ` Witold Szczeponik
2008-12-10  9:53 ` Henrique de Moraes Holschuh [this message]
2008-12-10 10:22   ` Oliver Neukum
2008-12-10 23:26     ` Henrique de Moraes Holschuh
2008-12-10 19:30   ` Witold Szczeponik
2008-12-10 23:21     ` Henrique de Moraes Holschuh
2008-12-11  1:28       ` Henrique de Moraes Holschuh
2008-12-11  1:50         ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081210095315.GA20627@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=Witold.Szczeponik@gmx.net \
    --cc=abelay@mit.edu \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox