Re: Fwd: [PATCH 01/02] Initial work to let ACPI buttons work over INPUT layer

Fabien Crespel
2009-01-15T12:31:46Z

Corentin Chary wrote:
> Hi,
> Just done a patch based on eeepc-laptop.
> You can get it there:
> http://git.iksaif.net/?p=acpi4asus.git;a=shortlog;h=refs/heads/asus-laptop-input
> I didn't test it yet, I'll only have my laptops this weekend.
> Could you test it please ?
> Thanks
>

Hello,

I haven't tested this patch, but there is a mistake in the keymap here:

{KE_KEY, 0x7D, KEY_BLUETOOTH}, /* Bluetooth up */
{KE_KEY, 0x7E, KEY_BLUETOOTH}, /* Bluetooth down */

These are not keys, they are notifications that occur *after* the bluetooth state
is changed by the firmware (by pressing the bluetooth key on some models, for
example). Therefore, they should not be reported to the input layer.

There is also a 0x88 scancode for the radio key on some models. On Windows, this
key cycles through radio states: WLAN + BT => WLAN => BT => None. AFAIK there is
no equivalent on Linux yet for such a key... What would be best to do to support it?

- Fabien.