From: Matthew Wilcox <matthew@wil.cx>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm <linux-pm@lists.linux-foundation.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-pci@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Len Brown <lenb@kernel.org>,
"Barnes, Jesse" <jesse.barnes@intel.com>
Subject: Re: [RFC PATCH 2/3] PCI: parallel resume for pci devices on bus 0
Date: Thu, 18 Dec 2008 23:49:04 -0700 [thread overview]
Message-ID: <20081219064903.GP19967@parisc-linux.org> (raw)
In-Reply-To: <1229668453.562.92.camel@rzhang-dt>
On Fri, Dec 19, 2008 at 02:34:13PM +0800, Zhang Rui wrote:
> + /* parallel resume for pci devices on bus 0 */
> + if (dev->bus->number == 0)
> + device_parallel_resume_register(&dev->dev, 1);
"bus 0" is presumably supposed to mean "devices on a root bus". I think
you should be checking for dev->bus->parent == NULL instead.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-12-19 6:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 6:34 [RFC PATCH 2/3] PCI: parallel resume for pci devices on bus 0 Zhang Rui
2008-12-19 6:49 ` Matthew Wilcox [this message]
2008-12-19 15:09 ` [linux-pm] " Alan Stern
2008-12-19 19:21 ` Len Brown
2008-12-22 2:56 ` Zhang Rui
2008-12-22 15:52 ` Alan Stern
2008-12-24 2:36 ` Zhang Rui
2008-12-24 2:47 ` Alan Stern
2009-01-16 6:24 ` Zhao Yakui
2009-01-16 15:10 ` Alan Stern
2009-01-17 7:31 ` Zhao Yakui
2009-01-17 17:15 ` Alan Stern
2009-01-19 1:10 ` Zhao Yakui
2009-01-16 6:24 ` Zhao Yakui
2009-01-16 1:55 ` Zhao Yakui
2009-01-16 15:05 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219064903.GP19967@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jesse.barnes@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox