From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
"trenn@suse.de" <trenn@suse.de>
Subject: Re: [PATCH] ACPI: disable the ACPI backlight control on laptops with buggy _BCL methods
Date: Fri, 9 Jan 2009 01:55:17 +0000 [thread overview]
Message-ID: <20090109015517.GA23621@srcf.ucam.org> (raw)
In-Reply-To: <1231466025.20746.107.camel@rzhang-dt>
On Fri, Jan 09, 2009 at 09:53:45AM +0800, Zhang Rui wrote:
> > If the value returned is less than the smallest value in the _BLC block,
> > then it's an index. This heuristic will never break a standards
> > compliant system, but (to the best of my knowledge) will work with any
> > of these systems that we're currently aware of.
> >
> well, this does work, but a little bit ugly...
> The ACPI backlight control on boxes with such _BCL/_BCM/_BQC methods
> implemented surely doesn't work before.
> so IMO disabling it again is not that bad. :)
We don't know how widespread this behaviour is. If Vista can cope with
it then we're likely to see machines that depend on it, so just hoping
that we can always punt it to a platform driver doesn't sound like the
best plan. If stock Vista is unable to deal with it then that's a
definite argument in favour of leaving it up to platform drivers.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2009-01-09 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 2:58 [PATCH] ACPI: disable the ACPI backlight control on laptops with buggy _BCL methods Zhang Rui
2009-01-08 3:11 ` Zhang Rui
2009-01-08 3:32 ` Matthew Garrett
2009-01-08 6:32 ` Zhang Rui
2009-01-08 12:43 ` Matthew Garrett
2009-01-09 1:13 ` Zhang Rui
2009-01-09 1:18 ` Matthew Garrett
2009-01-09 1:53 ` Zhang Rui
2009-01-09 1:55 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109015517.GA23621@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox