From: akpm@linux-foundation.org
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org,
valdis.kletnieks@vt.edu
Subject: [patch 5/6] drivers/acpi/hardware/hwsleep.c: fix warning msg
Date: Fri, 09 Jan 2009 12:17:12 -0800 [thread overview]
Message-ID: <200901092017.n09KHDk8015002@imap1.linux-foundation.org> (raw)
From: Valdis Kletnieks <valdis.kletnieks@vt.edu>
In mmotm1230 the linux.next patch, most likely via this commit:
commit ecd196686aee5028f71ee09072c8581c7293a847
Author: Len Brown <len.brown=40intel.com>
Date: Fri Dec 19 03:53:37 2008 -0500
ACPICA: disable ACPI 2.0 _GTS/_BFS support
added some warning messages:
CC drivers/acpi/hardware/hwsleep.o
drivers/acpi/hardware/hwsleep.c: In function`acpi_enter_sleep_state':
drivers/acpi/hardware/hwsleep.c:231: warning: unused variable`arg'
drivers/acpi/hardware/hwsleep.c:230: warning: unused variable`arg_list'
drivers/acpi/hardware/hwsleep.c: In function`acpi_leave_sleep_state_prep':
drivers/acpi/hardware/hwsleep.c:471: warning: unused variable`arg'
drivers/acpi/hardware/hwsleep.c:470: warning: unused variable`arg_list'
If we're going to ifdef-wrap the code, let's do the variables involved
as well, so we don't get warnings.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/hardware/hwsleep.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN drivers/acpi/hardware/hwsleep.c~drivers-acpi-hardware-hwsleepc-fix-warning-msg drivers/acpi/hardware/hwsleep.c
--- a/drivers/acpi/hardware/hwsleep.c~drivers-acpi-hardware-hwsleepc-fix-warning-msg
+++ a/drivers/acpi/hardware/hwsleep.c
@@ -227,8 +227,10 @@ acpi_status asmlinkage acpi_enter_sleep_
struct acpi_bit_register_info *sleep_type_reg_info;
struct acpi_bit_register_info *sleep_enable_reg_info;
u32 in_value;
+#ifdef ACPI_20_GTS_BFS
struct acpi_object_list arg_list;
union acpi_object arg;
+#endif
acpi_status status;
ACPI_FUNCTION_TRACE(acpi_enter_sleep_state);
@@ -467,8 +469,10 @@ ACPI_EXPORT_SYMBOL(acpi_enter_sleep_stat
******************************************************************************/
acpi_status acpi_leave_sleep_state_prep(u8 sleep_state)
{
+#ifdef ACPI_20_GTS_BFS
struct acpi_object_list arg_list;
union acpi_object arg;
+#endif
acpi_status status;
struct acpi_bit_register_info *sleep_type_reg_info;
struct acpi_bit_register_info *sleep_enable_reg_info;
_
next reply other threads:[~2009-01-09 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 20:17 akpm [this message]
2009-01-09 21:04 ` [patch 5/6] drivers/acpi/hardware/hwsleep.c: fix warning msg Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901092017.n09KHDk8015002@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox