Re: [PATCH 0/4] Fastboot revisited: Asynchronous function calls

Alan Cox
2009-01-04T21:44:38Z

> I _think_ it's the irq auto-probing, but that's just a guess. The 8250
> driver does some historical crud, like
>
> probe_irq_off(probe_irq_on());
>
> to get rid of any pending irq's, but that should be entirely pointless
> these days. I bet that line basically goes back to pre-history, before we
> made the auto-probing much stabler.

For non ISA boxes we shouldn't be - but this old code. The IRQ for the
built in ports is defined by convention, in the BIOS PnP tables or with
ACPI in the ACPI tables. So we shouldn't even be autoprobing the IRQ.

We *do* have to wait one transmission timeout or so to detect buggy uarts
but in theory that could be moved down into the open path.

Alan