From: Thomas Renninger <trenn@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Len Brown <lenb@kernel.org>, Zhao Yakui <yakui.zhao@intel.com>,
"Linux-acpi@vger.kernel.org" <Linux-acpi@vger.kernel.org>,
me@markdoughty.co.uk, ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt"
Date: Mon, 12 Jan 2009 15:13:04 +0100 [thread overview]
Message-ID: <200901121513.06126.trenn@suse.de> (raw)
In-Reply-To: <20090109123416.GA31003@srcf.ucam.org>
On Friday 09 January 2009 13:34:16 Matthew Garrett wrote:
> On Fri, Jan 09, 2009 at 01:16:15PM +0100, Thomas Renninger wrote:
> > IMO this cannot generally be done, because chances are high that machines
> > which do not support Windows likely will break.
> > Chances are high that a machine which does not support Windows uses 64
> > bit addresses and leaves the 32 bit ones uninitialized, a spec valid
> > configuration which will then break.
>
> Bear in mind that the values in the 32-bit entries are *io port*
> addresses, not physical memory addresses. There's only 16 bits of io
> ports, so the probability of the 64-bit values being programmed
> correctly and the 32-bit ones containing a valid but not-working set is
> tiny.
This is not about programming, but about a vendor just filling FADT values?
Why should someone fill up 32 bit values if the spec says that they get
ignored if you provide 64 bit ones (Because Windows is ..., but if you do
not support Windows and just follow the spec...)?
> If you know of any machines that behave this way, I'd be
> impressed - and it'll be far easier to dmi whitelist them than the other
> way around.
What do you mean with "easy"?
99.998% of all machines work fine with the current, spec conform
implementation.
There are the two ThinkPads for which the vendor admitted that the BIOS is
broken which work better with the rsdt blacklisted.
You want to change the default which is field tested and known to work on
all BIOSes (beside the two 5 year old broken ThinkPads)?
Thomas
PS: Leave the ThinkPads broken..., I am tired of arguing about this ...
next prev parent reply other threads:[~2009-01-12 14:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 18:42 [PATCH] ACPI: EC: clean up tmp variable before reuse Alexey Starikovskiy
2008-11-03 8:02 ` Zhao Yakui
2008-11-03 8:24 ` [PATCH]: ACPI: Initialize EC global lock based on the return value of _GLK Zhao Yakui
2008-11-04 7:41 ` [PATCH]: ACPI Cleanup :Initialize EC global lock based on the return status Zhao Yakui
2008-11-04 8:05 ` Alexey Starikovskiy
2008-11-04 8:58 ` Rafael J. Wysocki
2008-11-04 9:21 ` Alexey Starikovskiy
2008-11-04 9:37 ` Zhao Yakui
2008-11-04 9:38 ` Alexey Starikovskiy
2008-11-05 1:05 ` Zhao Yakui
2008-11-05 7:24 ` Alexey Starikovskiy
2008-12-17 8:55 ` [PATCH] : ACPI : Use RSDT instead of XSDT by adding boot option of "acpi=rsdt" Zhao Yakui
2009-01-09 6:35 ` Len Brown
2009-01-09 10:54 ` Thomas Renninger
2009-01-09 10:59 ` Len Brown
2009-01-09 12:16 ` Thomas Renninger
2009-01-09 12:34 ` Matthew Garrett
2009-01-12 14:13 ` Thomas Renninger [this message]
2009-01-12 14:16 ` Matthew Garrett
2009-01-12 22:17 ` Thomas Renninger
2009-01-12 23:38 ` Matthew Garrett
2009-01-09 10:58 ` Blacklist known broken machines to use the rsdt and enabled Cstates on R40e Thomas Renninger
2009-01-09 10:58 ` [PATCH 1/2] Blacklist known broken machines (ThinkPad R40e and R50e) to use rsdt instead xsdt Thomas Renninger
2009-01-09 10:58 ` [PATCH 2/2] R40e using rsdt (previous patch) makes all Cstates work -> remove blacklisting Thomas Renninger
2008-12-30 4:01 ` [PATCH] : ACPI : Add the MWAIT C-state mask to avoid overflow Zhao Yakui
2009-01-04 4:04 ` Zhao Yakui
2009-01-09 6:28 ` Len Brown
2009-01-12 7:07 ` [PATCH] : ACPI : Use clocksource to get the C-state time instead of ACPI PM timer Zhao Yakui
2009-01-12 7:58 ` Rafael J. Wysocki
2009-01-12 9:31 ` Zhao Yakui
2009-01-12 12:27 ` Rafael J. Wysocki
2009-01-12 9:39 ` Zhao Yakui
2009-01-12 22:09 ` Pallipadi, Venkatesh
2009-01-13 1:26 ` Zhao Yakui
2009-01-13 1:42 ` Zhao Yakui
2009-01-13 3:50 ` [RESEND] " Zhao Yakui
2009-01-20 2:52 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901121513.06126.trenn@suse.de \
--to=trenn@suse.de \
--cc=Linux-acpi@vger.kernel.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=me@markdoughty.co.uk \
--cc=mjg59@srcf.ucam.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox