Re: 2.6.29-rc1: Reported regressions from 2.6.28

Jaswinder Singh Rajput
2009-01-11T13:46:34Z

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> Subject : Build error on latest git
> Submitter : Petr Titera <P.Titera@century.cz>
> Date : 2009-01-11 9:49 (1 days old)
> References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> Handled-By : Petr Titera <P.Titera@century.cz>
> Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
>
>

This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
is defined.

I am still in the process of cleaning non-smp data from asm/smp.h for x86

Attach patch is the solution for the time being

Ingo, can you please put this in urgent queue.

Thanks
--
JSR

[-- Attachment #2: 0001-x86-mpparse.c-fix-compilation-error.patch --]
[-- Type: application/octet-stream, Size: 747 bytes --]

From 8e7b0d4ea4458f9966c54551ac0bd79b34d5f935 Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Date: Sun, 11 Jan 2009 18:30:34 +0530
Subject: [PATCH] x86: mpparse.c fix compilation error

Impact: fix compilation error

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/mpparse.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 8385d4e..79dae60 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -27,6 +27,7 @@
#include <asm/e820.h>
#include <asm/trampoline.h>
#include <asm/setup.h>
+#include <asm/smp.h>

#include <mach_apic.h>
#ifdef CONFIG_X86_32
--
1.5.6.6