From: Martin Lucina <mato@kotelna.sk>
To: Karthik Gopalakrishnan <karthik.g.krishnan@gmail.com>
Cc: linux-acpi@vger.kernel.org, laforge@gnumonks.org
Subject: Re: [RFC] [PATCH] panasonic-laptop.c: add support for CD power management
Date: Tue, 13 Jan 2009 20:14:04 +0100 [thread overview]
Message-ID: <20090113191402.GA4263@nodbug.moloch.sk> (raw)
In-Reply-To: <5e0a1fd80901130916x510395ddwdab40c867e32212b@mail.gmail.com>
Karthik,
karthik.g.krishnan@gmail.com said:
> To an end user, writing "0" to enable the device & "1" to disable it
> sounds counter-intuitive, especially when the sysfs entry is called
> "cdpower". Is there a reason to not flip that?
/me goes off to look at how other people do it... sony-laptop uses "1"
for on and "0" for off, so I guess you're right. Not sure what I was
thinking there, I'll flip it in the final version of the patch. Thanks!
Which brings me to a related question someone here may be able to
answer: Which bit of userspace would be responsible for managing the
drive's power state? To me the most intuitive automatic mode of
operation would be that the system powers off the drive after some time
iff there is no medium in the drive.
On these laptops there is no need to actually power the drive back up,
since it will do so automatically if a user attempts to insert a disc.
-mato
next prev parent reply other threads:[~2009-01-13 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 16:32 [RFC] [PATCH] panasonic-laptop.c: add support for CD power management Martin Lucina
2009-01-13 17:16 ` Karthik Gopalakrishnan
2009-01-13 19:14 ` Martin Lucina [this message]
2009-01-14 6:08 ` Harald Welte
2009-01-14 18:42 ` [PATCH] panasonic-laptop.c: add support for optical drive power control Martin Lucina
2009-04-05 4:53 ` Len Brown
2009-04-06 16:22 ` Martin Lucina
2009-04-07 5:59 ` Len Brown
2009-04-07 23:07 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113191402.GA4263@nodbug.moloch.sk \
--to=mato@kotelna.sk \
--cc=karthik.g.krishnan@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox