* [regression] hp-wmi: hangs system on boot
@ 2009-01-16 23:13 Frans Pop
2009-01-17 0:31 ` Frans Pop
0 siblings, 1 reply; 6+ messages in thread
From: Frans Pop @ 2009-01-16 23:13 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Larry Finger, Matthew Garrett, linux-acpi
When I first booted .29-rc2 my HP 2510p notebook hung while loading
hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed.
The last line on the console was:
input: HP WMI hotkeys as /class/input/input11
After commenting out hp-wmi in /etc/modules the system booted correctly.
After the successful boot I tried loading the module manually using
modprobe, which resulted in:
input: HP WMI hotkeys as /class/input/input11
iwlagn: Radio Frequency Kill Switch is On:
Kill switch must be turned off for wireless networking to work.
wlan0: No ProbeResp from current AP 00:14:c1:38:e5:15 - assume out of range
iwlagn: Error sending REPLY_ADD_STA: enqueue_hcmd failed: -5
mac80211-phy0: failed to remove key (0, 00:14:c1:38:e5:15) from hardware (-5)
iwlagn: Error sending REPLY_ADD_STA: enqueue_hcmd failed: -5
mac80211-phy0: failed to remove key (1, ff:ff:ff:ff:ff:ff) from hardware (-5)
I also noticed that /sys/bus/platform/devices/hp-wmi/dock is missing.
And I lost my wireless connection.
Difference between loading hp-wmi from /etc/modules and manually could be
that normally wlan is started _after_ /etc/modules is processed. So with
the hang wlan was not yet active, while for the manual modprobe wlan was
active.
With 2.6.28 hp-wmi works perfectly.
System is running x84_64, Debian Lenny.
Cheers,
FJP
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [regression] hp-wmi: hangs system on boot
2009-01-16 23:13 [regression] hp-wmi: hangs system on boot Frans Pop
@ 2009-01-17 0:31 ` Frans Pop
2009-01-17 0:52 ` Larry Finger
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
0 siblings, 2 replies; 6+ messages in thread
From: Frans Pop @ 2009-01-17 0:31 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Larry Finger, Matthew Garrett, linux-acpi
On Saturday 17 January 2009, Frans Pop wrote:
> When I first booted .29-rc2 my HP 2510p notebook hung while loading
> hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed.
Reverting the following commit fixes the problems:
commit fe8e4e039dc3680681bf51af097af391f87038f8
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date: Fri Jan 9 16:40:54 2009 -0800
hp-wmi: handle rfkill_register() failure
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [regression] hp-wmi: hangs system on boot
2009-01-17 0:31 ` Frans Pop
@ 2009-01-17 0:52 ` Larry Finger
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2009-01-17 0:52 UTC (permalink / raw)
To: Frans Pop; +Cc: Linux Kernel Mailing List, Matthew Garrett, linux-acpi
Frans Pop wrote:
> On Saturday 17 January 2009, Frans Pop wrote:
>> When I first booted .29-rc2 my HP 2510p notebook hung while loading
>> hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed.
>
> Reverting the following commit fixes the problems:
>
> commit fe8e4e039dc3680681bf51af097af391f87038f8
> Author: Larry Finger <Larry.Finger@lwfinger.net>
> Date: Fri Jan 9 16:40:54 2009 -0800
>
> hp-wmi: handle rfkill_register() failure
Ooops. There was a missing if statement. This one should fix it.
Index: linux-2.6/drivers/platform/x86/hp-wmi.c
===================================================================
--- linux-2.6.orig/drivers/platform/x86/hp-wmi.c
+++ linux-2.6/drivers/platform/x86/hp-wmi.c
@@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(stru
bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set;
bluetooth_rfkill->user_claim_unsupported = 1;
err = rfkill_register(bluetooth_rfkill);
+ if (err)
goto register_bluetooth_error;
}
-------
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] hp-wmi: fix regressions caused by missing if statement
2009-01-17 0:31 ` Frans Pop
2009-01-17 0:52 ` Larry Finger
@ 2009-01-17 0:55 ` Frans Pop
2009-01-17 0:57 ` Larry Finger
2009-01-17 1:48 ` Matthew Garrett
1 sibling, 2 replies; 6+ messages in thread
From: Frans Pop @ 2009-01-17 0:55 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Larry Finger, Matthew Garrett, linux-acpi, Andrew Morton
From: Frans Pop <elendil@planet.nl>
hp-wmi: fix regressions caused by missing if statement
Error was introduced in commit fe8e4e039dc3.
Signed-off-by: Frans Pop <elendil@planet.nl>
---
> On Saturday 17 January 2009, Frans Pop wrote:
> > When I first booted .29-rc2 my HP 2510p notebook hung while loading
> > hp-wmi, which I have listed in /etc/modules. Hard poweroff was
> > needed.
And this obvious patch fixes the regression (tested).
Andrew: I've added you as the broken patch also went via you.
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 7c789f0..6260420 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(struct
platform_device *device)
bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set;
bluetooth_rfkill->user_claim_unsupported = 1;
err = rfkill_register(bluetooth_rfkill);
+ if (err)
goto register_bluetooth_error;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] hp-wmi: fix regressions caused by missing if statement
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
@ 2009-01-17 0:57 ` Larry Finger
2009-01-17 1:48 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2009-01-17 0:57 UTC (permalink / raw)
To: Frans Pop
Cc: Linux Kernel Mailing List, Matthew Garrett, linux-acpi,
Andrew Morton
Frans Pop wrote:
> From: Frans Pop <elendil@planet.nl>
>
> hp-wmi: fix regressions caused by missing if statement
>
> Error was introduced in commit fe8e4e039dc3.
>
> Signed-off-by: Frans Pop <elendil@planet.nl>
> ---
>> On Saturday 17 January 2009, Frans Pop wrote:
>>> When I first booted .29-rc2 my HP 2510p notebook hung while loading
>>> hp-wmi, which I have listed in /etc/modules. Hard poweroff was
>>> needed.
>
> And this obvious patch fixes the regression (tested).
>
> Andrew: I've added you as the broken patch also went via you.
>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hp-wmi: fix regressions caused by missing if statement
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
2009-01-17 0:57 ` Larry Finger
@ 2009-01-17 1:48 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2009-01-17 1:48 UTC (permalink / raw)
To: Frans Pop
Cc: Linux Kernel Mailing List, Larry Finger, linux-acpi,
Andrew Morton
On Sat, Jan 17, 2009 at 01:55:01AM +0100, Frans Pop wrote:
> From: Frans Pop <elendil@planet.nl>
>
> hp-wmi: fix regressions caused by missing if statement
>
> Error was introduced in commit fe8e4e039dc3.
>
> Signed-off-by: Frans Pop <elendil@planet.nl>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-17 1:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-16 23:13 [regression] hp-wmi: hangs system on boot Frans Pop
2009-01-17 0:31 ` Frans Pop
2009-01-17 0:52 ` Larry Finger
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
2009-01-17 0:57 ` Larry Finger
2009-01-17 1:48 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox